Re: One test per line, one source per line, etc. etc. etc.

[DJ Delorie <dj@redhat.com>]

"Carlos O'Donell via Libc-alpha" <libc-alpha@sourceware.org> writes:
> Do we have consensus for someone to just cleanup all the makefiles
> to have one source per line, one test per line etc.?

Yes (again) :-)

I have two comments:

1. I use some sort of end-of-list tag, like this:

FILES = \
	a.c \
	b.c \
	$(ENDOFLIST)

or just $E or anything that expands to nothing.  Remnants of an old job
where adding the trailing \ to the previous line caused 100% patch
conflicts.  I'm not tied to any particular method, but I'm very against
the omit-last-slash format.

2. I recommend the files NOT be listed in strict alphabetical order,
when there's a large variance in build times.  List the files that take
longest, first.  Comment it as such, of course.  Leftovers from
libiberty's builds, where a parallel make spent most of its time waiting
for the ONE file that took forver to build, which was last in the
alphabetical list, so was always built by itself.