From: Florian Weimer <fweimer@redhat.com>
To: Carlos O'Donell via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: One test per line, one source per line, etc. etc. etc.
Date: Sun, 27 Jun 2021 22:14:09 +0200 [thread overview]
Message-ID: <875yxz12we.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <f6406204-84f5-adb1-d00e-979ebeebbbde@redhat.com> (Carlos O'Donell via Libc-alpha's message of "Sun, 27 Jun 2021 15:58:02 -0400")
* Carlos O'Donell via Libc-alpha:
> Do we have consensus for someone to just cleanup all the makefiles
> to have one source per line, one test per line etc.?
I think there was some opposition to trailing \ in lists in Makefiles.
This:
routines += \
read \
write \
vs:
routines += \
read \
write
> The more reviews I do, the more this causes my to stumble and have
> to work through merge issues.
>
> If I want to get to 100 patches reviewed per day I think this is going
> to block me.
Avoid merge conflicts also needs a custom merger (easier if the data is
in separate files with a more regular file).
Sorting the lists lexicographically avoids conflicts only
stochastically, for sufficiently long lists.
Thanks,
Florian
next prev parent reply other threads:[~2021-06-27 20:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-27 19:58 Carlos O'Donell
2021-06-27 20:14 ` Florian Weimer [this message]
2021-06-27 21:52 ` Carlos O'Donell
2021-06-28 7:24 ` Andreas Schwab
2021-06-28 11:42 ` Carlos O'Donell
2021-06-28 9:22 ` Dmitry V. Levin
2021-06-28 10:05 ` Florian Weimer
2021-06-28 11:45 ` Carlos O'Donell
2021-06-28 18:52 ` DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yxz12we.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).