* [PATCH] i386: Use generic memrchr in libc (bug 31316)
@ 2024-02-15 14:49 Florian Weimer
2024-02-15 15:08 ` Andreas Schwab
0 siblings, 1 reply; 4+ messages in thread
From: Florian Weimer @ 2024-02-15 14:49 UTC (permalink / raw)
To: libc-alpha; +Cc: Sam James
Before this change, we incorrectly use the SSE2 variant is the
implementation, without checking that the system actually supports
SSE2.
Tested-by: Sam James <sam@gentoo.org>
---
sysdeps/i386/i686/multiarch/memrchr-c.c | 1 +
sysdeps/i386/i686/multiarch/memrchr-sse2.S | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/sysdeps/i386/i686/multiarch/memrchr-c.c b/sysdeps/i386/i686/multiarch/memrchr-c.c
index ef7bbbe792..20bfdf3af3 100644
--- a/sysdeps/i386/i686/multiarch/memrchr-c.c
+++ b/sysdeps/i386/i686/multiarch/memrchr-c.c
@@ -5,3 +5,4 @@ extern void *__memrchr_ia32 (const void *, int, size_t);
#endif
#include "string/memrchr.c"
+strong_alias (__memrchr_ia32, __GI___memrchr)
diff --git a/sysdeps/i386/i686/multiarch/memrchr-sse2.S b/sysdeps/i386/i686/multiarch/memrchr-sse2.S
index d9dae04171..e123f87435 100644
--- a/sysdeps/i386/i686/multiarch/memrchr-sse2.S
+++ b/sysdeps/i386/i686/multiarch/memrchr-sse2.S
@@ -720,5 +720,4 @@ L(ret_null):
ret
END (__memrchr_sse2)
-strong_alias (__memrchr_sse2, __GI___memrchr)
#endif
base-commit: 491e55beab7457ed310a4a47496f4a333c5d1032
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] i386: Use generic memrchr in libc (bug 31316)
2024-02-15 14:49 [PATCH] i386: Use generic memrchr in libc (bug 31316) Florian Weimer
@ 2024-02-15 15:08 ` Andreas Schwab
2024-02-15 15:17 ` Florian Weimer
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Schwab @ 2024-02-15 15:08 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha, Sam James
On Feb 15 2024, Florian Weimer wrote:
> Before this change, we incorrectly use the SSE2 variant is the
s/ is / in /
> implementation, without checking that the system actually supports
> SSE2.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] i386: Use generic memrchr in libc (bug 31316)
2024-02-15 15:08 ` Andreas Schwab
@ 2024-02-15 15:17 ` Florian Weimer
2024-02-15 15:41 ` H.J. Lu
0 siblings, 1 reply; 4+ messages in thread
From: Florian Weimer @ 2024-02-15 15:17 UTC (permalink / raw)
To: Andreas Schwab; +Cc: libc-alpha, Sam James
* Andreas Schwab:
> On Feb 15 2024, Florian Weimer wrote:
>
>> Before this change, we incorrectly use the SSE2 variant is the
>
> s/ is / in /
>
>> implementation, without checking that the system actually supports
>> SSE2.
Thanks, fixed locally. Okay to push with that change?
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] i386: Use generic memrchr in libc (bug 31316)
2024-02-15 15:17 ` Florian Weimer
@ 2024-02-15 15:41 ` H.J. Lu
0 siblings, 0 replies; 4+ messages in thread
From: H.J. Lu @ 2024-02-15 15:41 UTC (permalink / raw)
To: Florian Weimer; +Cc: Andreas Schwab, libc-alpha, Sam James
On Thu, Feb 15, 2024 at 7:18 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * Andreas Schwab:
>
> > On Feb 15 2024, Florian Weimer wrote:
> >
> >> Before this change, we incorrectly use the SSE2 variant is the
> >
> > s/ is / in /
> >
> >> implementation, without checking that the system actually supports
> >> SSE2.
>
> Thanks, fixed locally. Okay to push with that change?
>
> Florian
>
Yes.
Thanks.
--
H.J.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-15 15:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-15 14:49 [PATCH] i386: Use generic memrchr in libc (bug 31316) Florian Weimer
2024-02-15 15:08 ` Andreas Schwab
2024-02-15 15:17 ` Florian Weimer
2024-02-15 15:41 ` H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).