public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* Missing audit17 test
@ 2022-01-15 15:45 Samuel Thibault
  2022-01-17 18:13 ` Adhemerval Zanella
  0 siblings, 1 reply; 2+ messages in thread
From: Samuel Thibault @ 2022-01-15 15:45 UTC (permalink / raw)
  To: libc-alpha

Hello,

9926f6e2eeb3 ("elf: Skip tst-auditlogmod-* if the linker doesn't support
--depaudit [BZ #28 151]") happened to be dropping tst-audit17:

diff --git a/elf/Makefile b/elf/Makefile
index 725537c40b..9f3fadc37e 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -219,7 +219,6 @@ tests += restest1 preloadtest loadfail multiload origtest resolvfail \
         tst-dlopen-self tst-auditmany tst-initfinilazyfail tst-dlopenfail \
         tst-dlopenfail-2 \
         tst-filterobj tst-filterobj-dlopen tst-auxobj tst-auxobj-dlopen \
-        tst-audit14 tst-audit15 tst-audit16 tst-audit17 \
         tst-single_threaded tst-single_threaded-pthread \
         tst-tls-ie tst-tls-ie-dlmopen argv0test \
         tst-glibc-hwcaps tst-glibc-hwcaps-prepend tst-glibc-hwcaps-mask \
@@ -238,6 +237,9 @@ selinux-enabled := $(shell cat /selinux/enforce 2> /dev/null)
 ifneq ($(selinux-enabled),1)
 tests-execstack-yes = tst-execstack tst-execstack-needed tst-execstack-prog
 endif
+ifeq ($(have-depaudit),yes)
+tests += tst-audit14 tst-audit15 tst-audit16
+endif
 endif
 tests += $(tests-execstack-$(have-z-execstack))
 ifeq ($(run-built-tests),yes)

was that expected?

Samuel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Missing audit17 test
  2022-01-15 15:45 Missing audit17 test Samuel Thibault
@ 2022-01-17 18:13 ` Adhemerval Zanella
  0 siblings, 0 replies; 2+ messages in thread
From: Adhemerval Zanella @ 2022-01-17 18:13 UTC (permalink / raw)
  To: Samuel Thibault, libc-alpha



On 15/01/2022 12:45, Samuel Thibault via Libc-alpha wrote:
> Hello,
> 
> 9926f6e2eeb3 ("elf: Skip tst-auditlogmod-* if the linker doesn't support
> --depaudit [BZ #28 151]") happened to be dropping tst-audit17:

Good catch, I will reinstate it.

> 
> diff --git a/elf/Makefile b/elf/Makefile
> index 725537c40b..9f3fadc37e 100644
> --- a/elf/Makefile
> +++ b/elf/Makefile
> @@ -219,7 +219,6 @@ tests += restest1 preloadtest loadfail multiload origtest resolvfail \
>          tst-dlopen-self tst-auditmany tst-initfinilazyfail tst-dlopenfail \
>          tst-dlopenfail-2 \
>          tst-filterobj tst-filterobj-dlopen tst-auxobj tst-auxobj-dlopen \
> -        tst-audit14 tst-audit15 tst-audit16 tst-audit17 \
>          tst-single_threaded tst-single_threaded-pthread \
>          tst-tls-ie tst-tls-ie-dlmopen argv0test \
>          tst-glibc-hwcaps tst-glibc-hwcaps-prepend tst-glibc-hwcaps-mask \
> @@ -238,6 +237,9 @@ selinux-enabled := $(shell cat /selinux/enforce 2> /dev/null)
>  ifneq ($(selinux-enabled),1)
>  tests-execstack-yes = tst-execstack tst-execstack-needed tst-execstack-prog
>  endif
> +ifeq ($(have-depaudit),yes)
> +tests += tst-audit14 tst-audit15 tst-audit16
> +endif
>  endif
>  tests += $(tests-execstack-$(have-z-execstack))
>  ifeq ($(run-built-tests),yes)
> 
> was that expected?
> 
> Samuel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-01-17 18:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-15 15:45 Missing audit17 test Samuel Thibault
2022-01-17 18:13 ` Adhemerval Zanella

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).