From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Adam Yi <ayi@janestreet.com>, libc-alpha@sourceware.org
Cc: joseph@codesourcery.com, i@adamyi.com
Subject: Re: [PATCH] hurd: fix build of tst-system.c
Date: Wed, 8 Mar 2023 08:48:49 -0300 [thread overview]
Message-ID: <90023151-aafa-c2e6-0666-3b5d98db3e06@linaro.org> (raw)
In-Reply-To: <E1pZp2P-008d3c-06@igm-qws-u21165a.delacy.com>
On 08/03/23 05:11, Adam Yi wrote:
> We made tst-system.c depend on pthread, but that requires linking with
> $(shared-thread-library). It does not fail under Linux because the
> variable expands to nothing under Linux, but it fails for Hurd.
>
> I tested verified via cross-compiling that "make check" now works
> for Hurd.
>
> Signed-off-by: Adam Yi <ayi@janestreet.com>
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> stdlib/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/stdlib/Makefile b/stdlib/Makefile
> index cd32f53b56..5e38f0e6a2 100644
> --- a/stdlib/Makefile
> +++ b/stdlib/Makefile
> @@ -281,6 +281,7 @@ LDLIBS-test-on_exit-race = $(shared-thread-library)
> LDLIBS-tst-canon-bz26341 = $(shared-thread-library)
> LDLIBS-tst-arc4random-fork = $(shared-thread-library)
> LDLIBS-tst-arc4random-thread = $(shared-thread-library)
> +LDLIBS-tst-system = $(shared-thread-library)
>
> LDLIBS-test-dlclose-exit-race = $(shared-thread-library)
> LDFLAGS-test-dlclose-exit-race = $(LDFLAGS-rdynamic)
prev parent reply other threads:[~2023-03-08 11:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 8:11 Adam Yi
2023-03-08 11:48 ` Adhemerval Zanella Netto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90023151-aafa-c2e6-0666-3b5d98db3e06@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=ayi@janestreet.com \
--cc=i@adamyi.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).