* [PATCH] hurd: fix build of tst-system.c
@ 2023-03-08 8:11 Adam Yi
2023-03-08 11:48 ` Adhemerval Zanella Netto
0 siblings, 1 reply; 2+ messages in thread
From: Adam Yi @ 2023-03-08 8:11 UTC (permalink / raw)
To: libc-alpha; +Cc: adhemerval.zanella, joseph, i, ayi
We made tst-system.c depend on pthread, but that requires linking with
$(shared-thread-library). It does not fail under Linux because the
variable expands to nothing under Linux, but it fails for Hurd.
I tested verified via cross-compiling that "make check" now works
for Hurd.
Signed-off-by: Adam Yi <ayi@janestreet.com>
---
stdlib/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/stdlib/Makefile b/stdlib/Makefile
index cd32f53b56..5e38f0e6a2 100644
--- a/stdlib/Makefile
+++ b/stdlib/Makefile
@@ -281,6 +281,7 @@ LDLIBS-test-on_exit-race = $(shared-thread-library)
LDLIBS-tst-canon-bz26341 = $(shared-thread-library)
LDLIBS-tst-arc4random-fork = $(shared-thread-library)
LDLIBS-tst-arc4random-thread = $(shared-thread-library)
+LDLIBS-tst-system = $(shared-thread-library)
LDLIBS-test-dlclose-exit-race = $(shared-thread-library)
LDFLAGS-test-dlclose-exit-race = $(LDFLAGS-rdynamic)
--
2.31.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] hurd: fix build of tst-system.c
2023-03-08 8:11 [PATCH] hurd: fix build of tst-system.c Adam Yi
@ 2023-03-08 11:48 ` Adhemerval Zanella Netto
0 siblings, 0 replies; 2+ messages in thread
From: Adhemerval Zanella Netto @ 2023-03-08 11:48 UTC (permalink / raw)
To: Adam Yi, libc-alpha; +Cc: joseph, i
On 08/03/23 05:11, Adam Yi wrote:
> We made tst-system.c depend on pthread, but that requires linking with
> $(shared-thread-library). It does not fail under Linux because the
> variable expands to nothing under Linux, but it fails for Hurd.
>
> I tested verified via cross-compiling that "make check" now works
> for Hurd.
>
> Signed-off-by: Adam Yi <ayi@janestreet.com>
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> stdlib/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/stdlib/Makefile b/stdlib/Makefile
> index cd32f53b56..5e38f0e6a2 100644
> --- a/stdlib/Makefile
> +++ b/stdlib/Makefile
> @@ -281,6 +281,7 @@ LDLIBS-test-on_exit-race = $(shared-thread-library)
> LDLIBS-tst-canon-bz26341 = $(shared-thread-library)
> LDLIBS-tst-arc4random-fork = $(shared-thread-library)
> LDLIBS-tst-arc4random-thread = $(shared-thread-library)
> +LDLIBS-tst-system = $(shared-thread-library)
>
> LDLIBS-test-dlclose-exit-race = $(shared-thread-library)
> LDFLAGS-test-dlclose-exit-race = $(LDFLAGS-rdynamic)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-08 11:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-08 8:11 [PATCH] hurd: fix build of tst-system.c Adam Yi
2023-03-08 11:48 ` Adhemerval Zanella Netto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).