* [PATCH] stdlib: Use long long int in stdlib/tst-llabs
@ 2023-05-16 20:56 Florian Weimer
2023-05-17 0:16 ` Siddhesh Poyarekar
0 siblings, 1 reply; 2+ messages in thread
From: Florian Weimer @ 2023-05-16 20:56 UTC (permalink / raw)
To: libc-alpha; +Cc: Siddhesh Poyarekar, Joe Simmons-Talbott
And adjust for GNU style.
---
stdlib/tst-llabs.c | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/stdlib/tst-llabs.c b/stdlib/tst-llabs.c
index be3cd78ceb..5e4d52def9 100644
--- a/stdlib/tst-llabs.c
+++ b/stdlib/tst-llabs.c
@@ -25,29 +25,29 @@
static int do_test (void)
{
- long i;
+ long long int i;
- TEST_COMPARE(llabs(LLONG_MAX), LLONG_MAX);
- TEST_COMPARE(llabs(LLONG_MIN + 1), LLONG_MAX);
- TEST_COMPARE(llabs(0x00000000ffffffffL), 0x00000000ffffffffL);
- TEST_COMPARE(llabs(0x0000000100000000L), 0x0000000100000000L);
- TEST_COMPARE(llabs(0x80000000ffffffffL), 0x7fffffff00000001L);
- TEST_COMPARE(llabs(0x8000000100000000L), 0x7fffffff00000000L);
- TEST_COMPARE(llabs(-1), 1);
- TEST_COMPARE(llabs(0), 0);
- TEST_COMPARE(llabs(1), 1);
+ TEST_COMPARE (llabs (LLONG_MAX), LLONG_MAX);
+ TEST_COMPARE (llabs (LLONG_MIN + 1), LLONG_MAX);
+ TEST_COMPARE (llabs (0x00000000ffffffffL), 0x00000000ffffffffL);
+ TEST_COMPARE (llabs (0x0000000100000000L), 0x0000000100000000L);
+ TEST_COMPARE (llabs (0x80000000ffffffffL), 0x7fffffff00000001L);
+ TEST_COMPARE (llabs (0x8000000100000000L), 0x7fffffff00000000L);
+ TEST_COMPARE (llabs (-1), 1);
+ TEST_COMPARE (llabs (0), 0);
+ TEST_COMPARE (llabs (1), 1);
for (i = LLONG_MIN + 1; i < LLONG_MIN + INT_MAX; i += LARGE_PRIME)
- TEST_COMPARE(llabs(i), -i);
+ TEST_COMPARE (llabs (i), -i);
for (i = LLONG_MAX - INT_MAX; i < LLONG_MAX - LARGE_PRIME; i += LARGE_PRIME)
- TEST_COMPARE(llabs(i), i);
+ TEST_COMPARE (llabs (i), i);
for (i = INT_MIN + 1; i < 0; i += LARGE_PRIME)
- TEST_COMPARE(llabs(i), -i);
+ TEST_COMPARE (llabs (i), -i);
for (i = 0; i < INT_MAX; i += LARGE_PRIME)
- TEST_COMPARE(llabs(i), i);
+ TEST_COMPARE (llabs (i), i);
return EXIT_SUCCESS;
}
base-commit: 89ade905c51a2488e85a28f9de413d8d9c1af82d
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] stdlib: Use long long int in stdlib/tst-llabs
2023-05-16 20:56 [PATCH] stdlib: Use long long int in stdlib/tst-llabs Florian Weimer
@ 2023-05-17 0:16 ` Siddhesh Poyarekar
0 siblings, 0 replies; 2+ messages in thread
From: Siddhesh Poyarekar @ 2023-05-17 0:16 UTC (permalink / raw)
To: Florian Weimer, libc-alpha; +Cc: Siddhesh Poyarekar, Joe Simmons-Talbott
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
On 2023-05-16 16:56, Florian Weimer via Libc-alpha wrote:
> And adjust for GNU style.
>
> ---
> stdlib/tst-llabs.c | 28 ++++++++++++++--------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/stdlib/tst-llabs.c b/stdlib/tst-llabs.c
> index be3cd78ceb..5e4d52def9 100644
> --- a/stdlib/tst-llabs.c
> +++ b/stdlib/tst-llabs.c
> @@ -25,29 +25,29 @@
>
> static int do_test (void)
> {
> - long i;
> + long long int i;
>
> - TEST_COMPARE(llabs(LLONG_MAX), LLONG_MAX);
> - TEST_COMPARE(llabs(LLONG_MIN + 1), LLONG_MAX);
> - TEST_COMPARE(llabs(0x00000000ffffffffL), 0x00000000ffffffffL);
> - TEST_COMPARE(llabs(0x0000000100000000L), 0x0000000100000000L);
> - TEST_COMPARE(llabs(0x80000000ffffffffL), 0x7fffffff00000001L);
> - TEST_COMPARE(llabs(0x8000000100000000L), 0x7fffffff00000000L);
> - TEST_COMPARE(llabs(-1), 1);
> - TEST_COMPARE(llabs(0), 0);
> - TEST_COMPARE(llabs(1), 1);
> + TEST_COMPARE (llabs (LLONG_MAX), LLONG_MAX);
> + TEST_COMPARE (llabs (LLONG_MIN + 1), LLONG_MAX);
> + TEST_COMPARE (llabs (0x00000000ffffffffL), 0x00000000ffffffffL);
> + TEST_COMPARE (llabs (0x0000000100000000L), 0x0000000100000000L);
> + TEST_COMPARE (llabs (0x80000000ffffffffL), 0x7fffffff00000001L);
> + TEST_COMPARE (llabs (0x8000000100000000L), 0x7fffffff00000000L);
> + TEST_COMPARE (llabs (-1), 1);
> + TEST_COMPARE (llabs (0), 0);
> + TEST_COMPARE (llabs (1), 1);
>
> for (i = LLONG_MIN + 1; i < LLONG_MIN + INT_MAX; i += LARGE_PRIME)
> - TEST_COMPARE(llabs(i), -i);
> + TEST_COMPARE (llabs (i), -i);
>
> for (i = LLONG_MAX - INT_MAX; i < LLONG_MAX - LARGE_PRIME; i += LARGE_PRIME)
> - TEST_COMPARE(llabs(i), i);
> + TEST_COMPARE (llabs (i), i);
>
> for (i = INT_MIN + 1; i < 0; i += LARGE_PRIME)
> - TEST_COMPARE(llabs(i), -i);
> + TEST_COMPARE (llabs (i), -i);
>
> for (i = 0; i < INT_MAX; i += LARGE_PRIME)
> - TEST_COMPARE(llabs(i), i);
> + TEST_COMPARE (llabs (i), i);
>
> return EXIT_SUCCESS;
> }
>
> base-commit: 89ade905c51a2488e85a28f9de413d8d9c1af82d
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-17 0:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-16 20:56 [PATCH] stdlib: Use long long int in stdlib/tst-llabs Florian Weimer
2023-05-17 0:16 ` Siddhesh Poyarekar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).