public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "Zack Weinberg" <zack@owlfolio.org>
To: "Florian Weimer" <fweimer@redhat.com>,
	"Paul Eggert" <eggert@cs.ucla.edu>
Cc: "Siddhesh Poyarekar" <siddhesh@gotplt.org>,
	"Vincent Lefevre" <vincent@vinc17.net>,
	"Xi Ruoyao" <xry111@xry111.site>,
	"Adhemerval Zanella" <adhemerval.zanella@linaro.org>,
	"Turritopsis Dohrnii Teo En Ming" <teo.en.ming@protonmail.com>,
	"GNU libc development" <libc-alpha@sourceware.org>,
	"ceo@teo-en-ming-corp.com" <ceo@teo-en-ming-corp.com>
Subject: Re: New GNU C Library (glibc) security flaw reported on 30 Jan 2024
Date: Mon, 22 Apr 2024 10:39:09 -0400	[thread overview]
Message-ID: <90ac2925-a833-4a2c-a7f7-9c28276b9222@app.fastmail.com> (raw)
In-Reply-To: <87bk6k1coe.fsf@oldenburg.str.redhat.com>

On Mon, Apr 8, 2024, at 4:28 AM, Florian Weimer wrote:
> * Paul Eggert:
>>  the same array element should always compare the same way with
>>  the key.
>
> I don't think the requirement described in the last line actually
> exists.  Some applications likely reuse the same key object to search
> for different values, and the requirement might prohibit that (but it
> is ambiguous).

I believe what Paul was trying to express here is that *during a single
call to bsearch*, repeated calls to the comparison function with the
same (key, element) pair should return the same result.

In between calls to bsearch, the application is allowed to modify both
the array and the key object, so there cannot be any expectation for the
comparison function to return the same result for the same pair of
*addresses* -- (&key, &element) -- on a second call to bsearch. I see
how the quoted sentence could read that way, though, and I'm not sure
how to fix it.

zw

  reply	other threads:[~2024-04-22 15:31 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31 14:08 Turritopsis Dohrnii Teo En Ming
2024-01-31 14:23 ` Xi Ruoyao
2024-01-31 14:55   ` Vincent Lefevre
2024-01-31 15:52     ` Adhemerval Zanella Netto
2024-01-31 16:23       ` Vincent Lefevre
2024-01-31 16:44         ` Siddhesh Poyarekar
2024-01-31 18:47       ` Xi Ruoyao
2024-02-01  0:51         ` Vincent Lefevre
2024-02-01  1:03           ` Vincent Lefevre
2024-02-01  6:41           ` Xi Ruoyao
2024-02-01  9:07             ` Vincent Lefevre
2024-02-01 19:55               ` Paul Eggert
2024-02-01 21:11                 ` Siddhesh Poyarekar
2024-02-05  0:58                   ` Paul Eggert
2024-02-06 15:00                     ` Zack Weinberg
2024-02-06 21:30                       ` Paul Eggert
2024-02-06 22:04                         ` Xi Ruoyao
2024-02-07 17:07                         ` Zack Weinberg
2024-02-07 19:55                           ` Alexander Monakov
2024-02-07 20:45                             ` Zack Weinberg
2024-02-07 21:53                               ` Alexander Monakov
2024-02-07 22:56                               ` Paul Eggert
2024-04-06 17:17                           ` Paul Eggert
2024-04-08  8:28                             ` Florian Weimer
2024-04-22 14:39                               ` Zack Weinberg [this message]
2024-04-23 18:09                                 ` Paul Eggert
2024-04-23 18:26                                   ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90ac2925-a833-4a2c-a7f7-9c28276b9222@app.fastmail.com \
    --to=zack@owlfolio.org \
    --cc=adhemerval.zanella@linaro.org \
    --cc=ceo@teo-en-ming-corp.com \
    --cc=eggert@cs.ucla.edu \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=siddhesh@gotplt.org \
    --cc=teo.en.ming@protonmail.com \
    --cc=vincent@vinc17.net \
    --cc=xry111@xry111.site \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).