public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Alejandro Colomar <alx.manpages@gmail.com>
To: Jonny Grant <jg@jguk.org>, Florian Weimer <fweimer@redhat.com>
Cc: Michael Kerrisk <mtk.manpages@gmail.com>,
	linux-man <linux-man@vger.kernel.org>,
	GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Add example to rand.3
Date: Mon, 26 Dec 2022 23:29:14 +0100	[thread overview]
Message-ID: <92e5ad68-d013-43f5-cc3e-459daea93a83@gmail.com> (raw)
In-Reply-To: <105835f5-359c-2646-f609-e73459ee2d3b@jguk.org>


[-- Attachment #1.1: Type: text/plain, Size: 1542 bytes --]

Hi Jonny,

On 12/26/22 22:50, Jonny Grant wrote:
> Hi Alejandro

Please send also to my email.

> Please find below a patch.
> 
> 2022-12-26  Jonathan Grant <jg@jguk.org>
> 	* man3/rand.3: Add example to rand.3 seed with time(NULL)
> 
> 
>  From 2d4501354ea6c465173fe6c089dfbcc80393a644 Mon Sep 17 00:00:00 2001
> From: Jonathan Grant <jg@jguk.org>
> Date: Mon, 26 Dec 2022 21:48:17 +0000
> Subject: [PATCH] add rand.3 example
> 
> Signed-off-by: Jonathan Grant <jg@jguk.org>

time(NULL) is not too good.  If you call it several times per second, you'll 
find that it only changes the seed every second.  There are better ways to 
produce a good seed.

However, I prefer suggesting arc4random() rather than workarounding rand(3) to 
get good results.

Florian, did you already merge arc4random() to glibc?

Cheers,

Alex

> ---
>   man3/rand.3 | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 
> diff --git a/man3/rand.3 b/man3/rand.3
> index 572471749..c1542fb56 100644
> --- a/man3/rand.3
> +++ b/man3/rand.3
> @@ -164,6 +164,20 @@ when good randomness is needed.
>   .BR random (3)
>   instead.)
>   .SH EXAMPLES
> +
> +A possibly useful seed value would be by calling
> +.BR rand ()
> +with the result of
> +
> +.BR time ()
> +as that varies with every call
> +
> +.EX
> +srand((unsigned int)time(NULL));
> +.EE
> +.in
> +.PP
> +
>   POSIX.1-2001 gives the following example of an implementation of
>   .BR rand ()
>   and

-- 
<http://www.alejandro-colomar.es/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

       reply	other threads:[~2022-12-26 22:29 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <105835f5-359c-2646-f609-e73459ee2d3b@jguk.org>
2022-12-26 22:29 ` Alejandro Colomar [this message]
2022-12-27 13:07   ` Cristian Rodríguez
2022-12-27 23:33     ` Alejandro Colomar
2022-12-28  0:00       ` G. Branden Robinson
2022-12-28  0:41         ` Alejandro Colomar
2022-12-28 12:21           ` Cristian Rodríguez
2022-12-30 18:15             ` Joseph Myers
2022-12-30 18:20               ` Alejandro Colomar
2022-12-30 18:50                 ` Joseph Myers
2022-12-30 18:58                   ` Alejandro Colomar
2022-12-30 19:11               ` Cristian Rodríguez
2022-12-30 21:08                 ` Joseph Myers
2022-12-30 21:15                   ` Internal organization of "the implementation" (was: [PATCH] Add example to rand.3) Alejandro Colomar
2022-12-30 21:50                     ` Joseph Myers
2022-12-27 21:37   ` [PATCH] Add example to rand.3 Jonny Grant
2022-12-27 23:11     ` Alejandro Colomar
2022-12-28 20:51       ` Jonny Grant
2022-12-28 20:56         ` Alejandro Colomar
2022-12-28 21:03           ` Alejandro Colomar
2022-12-28 21:04             ` Alejandro Colomar
2022-12-28 21:25               ` Jonny Grant
2022-12-28 21:32                 ` Alejandro Colomar
2022-12-28 21:04           ` Cristian Rodríguez
2022-12-28 21:11             ` Alejandro Colomar
2022-12-28 21:19               ` Jonny Grant
2022-12-28 21:18             ` Alejandro Colomar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92e5ad68-d013-43f5-cc3e-459daea93a83@gmail.com \
    --to=alx.manpages@gmail.com \
    --cc=fweimer@redhat.com \
    --cc=jg@jguk.org \
    --cc=libc-alpha@sourceware.org \
    --cc=linux-man@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).