[RFC] Patch review volunteers

[RFC] Patch review volunteers

[Maxim Kuvyrkov]

Hi All,

TL;DR: Answer "yes, I volunteer" to this email.

Glibc community has a "Patchwork Review Meeting" [1] where we try to assign patches waiting for review to various glibc developers.  One challenge, though, is that the current practice is to pick reviewers from the people who happened to join a particular meeting.  This process doesn't scale since the number of patches glibc project is receiving is substantially bigger than the number of developers joining the patch review meeting.

We are seeking volunteers to join the patch reviewer pool to whom we can distribute the load of incoming patches.  You agree to be assigned a few patches per week and review them in a reasonable timeframe.  If you start joining the review meetings (on Mondays) -- even better!

We are guessing that a pool of 20 volunteers would be enough to cope with Glibc's current patch influx.  This would translate into each volunteer reviewing 1-2 patches (or short patch series) per week.

You don't have to be a senior developer to join patch review.  We will have a smaller pool of senior developers who will help with advice and mentorship when you get assigned to a particularly difficult patch.  Joining the patch reviewer pool is a great way to develop your upstream skills.

Are you joining the patch review volunteers?


Disclaimer:
Note, that "patch review" and "patch approval" are different things.  Being assigned as patch reviewer is not a grant of a right to unilaterally approve the patch.  The usual patch approval process still applies.

[1] https://sourceware.org/glibc/wiki/PatchworkReviewMeetings

--
Maxim Kuvyrkov
https://www.linaro.org

Re: [RFC] Patch review volunteers

[Carlos O'Donell]

On 2/5/24 12:45, Maxim Kuvyrkov wrote:
> Hi All,
> 
> TL;DR: Answer "yes, I volunteer" to this email.

Yes, I volunteer!

> Glibc community has a "Patchwork Review Meeting" [1] where we try to assign patches waiting for review to various glibc developers.  One challenge, though, is that the current practice is to pick reviewers from the people who happened to join a particular meeting.  This process doesn't scale since the number of patches glibc project is receiving is substantially bigger than the number of developers joining the patch review meeting.
> 
> We are seeking volunteers to join the patch reviewer pool to whom we can distribute the load of incoming patches.  You agree to be assigned a few patches per week and review them in a reasonable timeframe.  If you start joining the review meetings (on Mondays) -- even better!
> 
> We are guessing that a pool of 20 volunteers would be enough to cope with Glibc's current patch influx.  This would translate into each volunteer reviewing 1-2 patches (or short patch series) per week.
> 
> You don't have to be a senior developer to join patch review.  We will have a smaller pool of senior developers who will help with advice and mentorship when you get assigned to a particularly difficult patch.  Joining the patch reviewer pool is a great way to develop your upstream skills.
> 
> Are you joining the patch review volunteers?
> 
> 
> Disclaimer:
> Note, that "patch review" and "patch approval" are different things.  Being assigned as patch reviewer is not a grant of a right to unilaterally approve the patch.  The usual patch approval process still applies.
> 
> [1] https://sourceware.org/glibc/wiki/PatchworkReviewMeetings
> 
> --
> Maxim Kuvyrkov
> https://www.linaro.org
> 

-- 
Cheers,
Carlos.

Re: [RFC] Patch review volunteers

[Arjun Shankar]

> TL;DR: Answer "yes, I volunteer" to this email.

yes, I volunteer

Re: [RFC] Patch review volunteers

[Florian Weimer]

* Maxim Kuvyrkov:

> Are you joining the patch review volunteers?

Please include me among the volunteers.

Thanks,
Florian

Re: [RFC] Patch review volunteers

[Maxim Kuvyrkov]

> On Mar 11, 2024, at 22:31, Florian Weimer <fweimer@redhat.com> wrote:
> 
> * Maxim Kuvyrkov:
> 
>> Are you joining the patch review volunteers?
> 
> Please include me among the volunteers.

Thanks, Florian; added.

For the record, the list of patch review volunteers is at [1], and anyone can add himself/herself by editing the wiki.

[1] https://sourceware.org/glibc/wiki/PatchworkReviewMeetings

--
Maxim Kuvyrkov
https://www.linaro.org