From: Arjun Shankar <arjun@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] s390: Fix build for -march=z13
Date: Mon, 20 Feb 2023 21:03:00 +0100 [thread overview]
Message-ID: <CAG_osaZ_TCbNOf3Tae=xxP4-JdvVw58Uv+j_RKL91Og+1CU8ZA@mail.gmail.com> (raw)
In-Reply-To: <20230220142356.1180570-1-adhemerval.zanella@linaro.org>
Hi Adhemerval,
> It fixes the build after 7ea510127e2067e and 22999b2f0fb62.
>
> Checked with build for s390x-linux-gnu with -march=z13.
Thanks! This LGTM, and fixes a build failure on master with Fedora
Rawhide on s390x (which uses -march=z13).
Reviewed-by: Arjun Shankar <arjun@redhat.com>
> ---
> sysdeps/s390/memrchr-vx.S | 1 +
> sysdeps/s390/strchrnul-vx.S | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/sysdeps/s390/memrchr-vx.S b/sysdeps/s390/memrchr-vx.S
> index c6c3168668..4080dccfbc 100644
> --- a/sysdeps/s390/memrchr-vx.S
> +++ b/sysdeps/s390/memrchr-vx.S
> @@ -161,6 +161,7 @@ ENTRY(MEMRCHR_Z13)
> END(MEMRCHR_Z13)
>
> # if ! HAVE_MEMRCHR_IFUNC
> +libc_hidden_def (__memrchr)
> strong_alias (MEMRCHR_Z13, __memrchr)
> weak_alias (__memrchr, memrchr)
> # endif
> diff --git a/sysdeps/s390/strchrnul-vx.S b/sysdeps/s390/strchrnul-vx.S
> index 07f39426b7..b705979481 100644
> --- a/sysdeps/s390/strchrnul-vx.S
> +++ b/sysdeps/s390/strchrnul-vx.S
> @@ -94,6 +94,7 @@ ENTRY(STRCHRNUL_Z13)
> END(STRCHRNUL_Z13)
>
> # if ! HAVE_STRCHRNUL_IFUNC
> +libc_hidden_def (__strchrnul)
> strong_alias (STRCHRNUL_Z13, __strchrnul)
> weak_alias (__strchrnul, strchrnul)
> # endif
> --
> 2.34.1
>
prev parent reply other threads:[~2023-02-20 20:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 14:23 Adhemerval Zanella
2023-02-20 20:03 ` Arjun Shankar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG_osaZ_TCbNOf3Tae=xxP4-JdvVw58Uv+j_RKL91Og+1CU8ZA@mail.gmail.com' \
--to=arjun@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).