public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] s390: Fix build for -march=z13
@ 2023-02-20 14:23 Adhemerval Zanella
  2023-02-20 20:03 ` Arjun Shankar
  0 siblings, 1 reply; 2+ messages in thread
From: Adhemerval Zanella @ 2023-02-20 14:23 UTC (permalink / raw)
  To: libc-alpha, Arjun Shankar

It fixes the build after 7ea510127e2067e and 22999b2f0fb62.

Checked with build for s390x-linux-gnu with -march=z13.
---
 sysdeps/s390/memrchr-vx.S   | 1 +
 sysdeps/s390/strchrnul-vx.S | 1 +
 2 files changed, 2 insertions(+)

diff --git a/sysdeps/s390/memrchr-vx.S b/sysdeps/s390/memrchr-vx.S
index c6c3168668..4080dccfbc 100644
--- a/sysdeps/s390/memrchr-vx.S
+++ b/sysdeps/s390/memrchr-vx.S
@@ -161,6 +161,7 @@ ENTRY(MEMRCHR_Z13)
 END(MEMRCHR_Z13)
 
 # if ! HAVE_MEMRCHR_IFUNC
+libc_hidden_def (__memrchr)
 strong_alias (MEMRCHR_Z13, __memrchr)
 weak_alias (__memrchr, memrchr)
 # endif
diff --git a/sysdeps/s390/strchrnul-vx.S b/sysdeps/s390/strchrnul-vx.S
index 07f39426b7..b705979481 100644
--- a/sysdeps/s390/strchrnul-vx.S
+++ b/sysdeps/s390/strchrnul-vx.S
@@ -94,6 +94,7 @@ ENTRY(STRCHRNUL_Z13)
 END(STRCHRNUL_Z13)
 
 # if ! HAVE_STRCHRNUL_IFUNC
+libc_hidden_def (__strchrnul)
 strong_alias (STRCHRNUL_Z13, __strchrnul)
 weak_alias (__strchrnul, strchrnul)
 # endif
-- 
2.34.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] s390: Fix build for -march=z13
  2023-02-20 14:23 [PATCH] s390: Fix build for -march=z13 Adhemerval Zanella
@ 2023-02-20 20:03 ` Arjun Shankar
  0 siblings, 0 replies; 2+ messages in thread
From: Arjun Shankar @ 2023-02-20 20:03 UTC (permalink / raw)
  To: Adhemerval Zanella; +Cc: libc-alpha

Hi Adhemerval,

> It fixes the build after 7ea510127e2067e and 22999b2f0fb62.
>
> Checked with build for s390x-linux-gnu with -march=z13.

Thanks! This LGTM, and fixes a build failure on master with Fedora
Rawhide on s390x (which uses -march=z13).

Reviewed-by: Arjun Shankar <arjun@redhat.com>

> ---
>  sysdeps/s390/memrchr-vx.S   | 1 +
>  sysdeps/s390/strchrnul-vx.S | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/sysdeps/s390/memrchr-vx.S b/sysdeps/s390/memrchr-vx.S
> index c6c3168668..4080dccfbc 100644
> --- a/sysdeps/s390/memrchr-vx.S
> +++ b/sysdeps/s390/memrchr-vx.S
> @@ -161,6 +161,7 @@ ENTRY(MEMRCHR_Z13)
>  END(MEMRCHR_Z13)
>
>  # if ! HAVE_MEMRCHR_IFUNC
> +libc_hidden_def (__memrchr)
>  strong_alias (MEMRCHR_Z13, __memrchr)
>  weak_alias (__memrchr, memrchr)
>  # endif
> diff --git a/sysdeps/s390/strchrnul-vx.S b/sysdeps/s390/strchrnul-vx.S
> index 07f39426b7..b705979481 100644
> --- a/sysdeps/s390/strchrnul-vx.S
> +++ b/sysdeps/s390/strchrnul-vx.S
> @@ -94,6 +94,7 @@ ENTRY(STRCHRNUL_Z13)
>  END(STRCHRNUL_Z13)
>
>  # if ! HAVE_STRCHRNUL_IFUNC
> +libc_hidden_def (__strchrnul)
>  strong_alias (STRCHRNUL_Z13, __strchrnul)
>  weak_alias (__strchrnul, strchrnul)
>  # endif
> --
> 2.34.1
>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-02-20 20:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-20 14:23 [PATCH] s390: Fix build for -march=z13 Adhemerval Zanella
2023-02-20 20:03 ` Arjun Shankar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).