* [PATCH] x86_64: Disable libmvec tests if multiarch not enabled [BZ# 28869]
@ 2022-02-23 22:42 Sunil K Pandey
2022-02-23 22:54 ` H.J. Lu
0 siblings, 1 reply; 2+ messages in thread
From: Sunil K Pandey @ 2022-02-23 22:42 UTC (permalink / raw)
To: libc-alpha
This patch disable libmvec math tests if multiarch not enabled.
This fixes [BZ# 28869]
---
sysdeps/x86_64/fpu/Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sysdeps/x86_64/fpu/Makefile b/sysdeps/x86_64/fpu/Makefile
index 9fb587cf8f..8278ce104a 100644
--- a/sysdeps/x86_64/fpu/Makefile
+++ b/sysdeps/x86_64/fpu/Makefile
@@ -24,6 +24,8 @@ libmvec-support += \
$(addprefix svml_s_,$(addsuffix $(l),$(libmvec-funcs))))
endif
+# Do not run libmvec tests if multiarch not enabled.
+ifneq ($(multi-arch),no)
# Variables for libmvec tests.
ifeq ($(subdir)$(build-mathvec),mathyes)
libmvec-tests += double-vlen2 double-vlen4 double-vlen4-avx2 \
@@ -112,3 +114,4 @@ $(objpfx)bench-double-%.c: $(bench-libmvec-deps)
$(PYTHON) $(..)sysdeps/x86_64/fpu/scripts/bench_libmvec.py $(basename $(@F)); } > $@-tmp
mv -f $@-tmp $@
endif
+endif
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86_64: Disable libmvec tests if multiarch not enabled [BZ# 28869]
2022-02-23 22:42 [PATCH] x86_64: Disable libmvec tests if multiarch not enabled [BZ# 28869] Sunil K Pandey
@ 2022-02-23 22:54 ` H.J. Lu
0 siblings, 0 replies; 2+ messages in thread
From: H.J. Lu @ 2022-02-23 22:54 UTC (permalink / raw)
To: Sunil K Pandey; +Cc: GNU C Library
On Wed, Feb 23, 2022 at 2:43 PM Sunil K Pandey <skpgkp2@gmail.com> wrote:
>
> This patch disable libmvec math tests if multiarch not enabled.
>
> This fixes [BZ# 28869]
> ---
> sysdeps/x86_64/fpu/Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/sysdeps/x86_64/fpu/Makefile b/sysdeps/x86_64/fpu/Makefile
> index 9fb587cf8f..8278ce104a 100644
> --- a/sysdeps/x86_64/fpu/Makefile
> +++ b/sysdeps/x86_64/fpu/Makefile
> @@ -24,6 +24,8 @@ libmvec-support += \
> $(addprefix svml_s_,$(addsuffix $(l),$(libmvec-funcs))))
> endif
>
> +# Do not run libmvec tests if multiarch not enabled.
> +ifneq ($(multi-arch),no)
> # Variables for libmvec tests.
> ifeq ($(subdir)$(build-mathvec),mathyes)
> libmvec-tests += double-vlen2 double-vlen4 double-vlen4-avx2 \
> @@ -112,3 +114,4 @@ $(objpfx)bench-double-%.c: $(bench-libmvec-deps)
> $(PYTHON) $(..)sysdeps/x86_64/fpu/scripts/bench_libmvec.py $(basename $(@F)); } > $@-tmp
> mv -f $@-tmp $@
> endif
> +endif
> --
> 2.34.1
>
LGTM.
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
Thanks.
--
H.J.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-23 22:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-23 22:42 [PATCH] x86_64: Disable libmvec tests if multiarch not enabled [BZ# 28869] Sunil K Pandey
2022-02-23 22:54 ` H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).