From: Sergey Bugaev <bugaevc@gmail.com>
To: Andreas Schwab <schwab@suse.de>
Cc: libc-alpha@sourceware.org
Subject: Re: [RFC PATCH 1/6] Mark more functions as __COLD
Date: Mon, 15 May 2023 18:27:55 +0300 [thread overview]
Message-ID: <CAN9u=Hd+RBtKiLOfRcX89pf2YK5FQDh_x8VCMrYbaAgnkynmwg@mail.gmail.com> (raw)
In-Reply-To: <mvmjzx9k4b8.fsf@suse.de>
On Mon, May 15, 2023 at 6:22 PM Andreas Schwab <schwab@suse.de> wrote:
> Any reason you replaced _Noreturn with __attribute__ ((__noreturn__))
> here ...
> ... but did the other way here?
Thank you for spotting, that was not intentional (in fact I thought I
got rid of the noreturn tweaks when git add -p'ing... evidently not
entirely).
I *think* the _Noreturn form is / should be the preferred one, both
because it's actual C syntax, and because it's defined to
__attrbiute__ ((noreturn)) only when the compiler supports it?
Sergey
next prev parent reply other threads:[~2023-05-15 15:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 14:48 [RFC PATCH 0/6] .text.subsections for some questionable benefit Sergey Bugaev
2023-05-15 14:48 ` [RFC PATCH 1/6] Mark more functions as __COLD Sergey Bugaev
2023-05-15 15:22 ` Andreas Schwab
2023-05-15 15:27 ` Sergey Bugaev [this message]
2023-05-18 17:06 ` [PATCH v2] " Sergey Bugaev
2023-05-18 19:43 ` Adhemerval Zanella Netto
2023-05-19 10:35 ` Sergey Bugaev
2023-05-22 20:41 ` Adhemerval Zanella Netto
2023-05-15 14:48 ` [RFC PATCH 2/6] mcheck: Microoptimize Sergey Bugaev
2023-05-15 14:48 ` [RFC PATCH 3/6] sys/cdefs.h: Define __TEXT_STARTUP & __TEXT_EXIT Sergey Bugaev
2023-05-15 14:48 ` [RFC PATCH 4/6] Mark various functions as __TEXT_STARTUP and __TEXT_EXIT Sergey Bugaev
2023-05-15 14:48 ` [RFC PATCH 5/6] Also place entry points into .text.startup Sergey Bugaev
2023-05-15 14:48 ` [RFC PATCH 6/6] mach: In rtld, mark MIG routines as __TEXT_STARTUP Sergey Bugaev
2023-05-15 15:33 ` [RFC PATCH 0/6] .text.subsections for some questionable benefit Cristian Rodríguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN9u=Hd+RBtKiLOfRcX89pf2YK5FQDh_x8VCMrYbaAgnkynmwg@mail.gmail.com' \
--to=bugaevc@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).