Re: [RFC PATCH 1/6] Mark more functions as __COLD

[Andreas Schwab <schwab@suse.de>]

On Mai 15 2023, Sergey Bugaev via Libc-alpha wrote:

> diff --git a/include/stdio.h b/include/stdio.h
> index da47d1ce..b5257dd5 100644
> --- a/include/stdio.h
> +++ b/include/stdio.h
> @@ -171,9 +171,11 @@ extern int __gen_tempname (char *__tmpl, int __suffixlen, int __flags,
>  /* Print out MESSAGE (which should end with a newline) on the error output
>     and abort.  */
>  extern void __libc_fatal (const char *__message)
> -     __attribute__ ((__noreturn__));
> -_Noreturn void __libc_message (const char *__fnt, ...) attribute_hidden;
> -extern void __fortify_fail (const char *msg) __attribute__ ((__noreturn__));
> +     __attribute__ ((__noreturn__)) __COLD;
> +extern void __libc_message (const char *__fnt, ...)
> +     attribute_hidden __attribute__ ((__noreturn__)) __COLD;

Any reason you replaced _Noreturn with __attribute__ ((__noreturn__))
here ...

> diff --git a/malloc/malloc.c b/malloc/malloc.c
> index 5d8b61d6..75e4eb2f 100644
> --- a/malloc/malloc.c
> +++ b/malloc/malloc.c
> @@ -1093,7 +1093,7 @@ static void*  _int_memalign(mstate, size_t, size_t);
>  static void*  _mid_memalign(size_t, size_t, void *);
>  #endif
>  
> -static void malloc_printerr(const char *str) __attribute__ ((noreturn));
> +_Noreturn static void malloc_printerr(const char *str) __COLD;

... but did the other way here?

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."