Re: [PATCH 0/3] Add tests for abs(), labs(), llabs() (BZ #30263)

Re: [PATCH 0/3] Add tests for abs(), labs(), llabs() (BZ #30263)

[Wilco Dijkstra]

Hi Joe,

> Add testcases for abs(), labs(), and llabs().  Test the bounds of the
> given type, zero, and part of the full range of values for labs() and
> llabs().  Test the full range for abs().

How long do these tests take on older, slower cores? You're running
over 20 billion tests in total - at say 10 cycles per test a 2GHz CPU
would take 100 seconds which is way overkill for these basic functions.

Try using a larger increment (eg. prime) so that you cover the range
and the test will run within a second on a slow core. And for llabs it
makes sense to add tests for the carry when the bottom 32 bits are
zero to the top 32 bits (think 32-bit targets here).

Cheers,
Wilco

[PATCH 0/3] Add tests for abs(), labs(), llabs() (BZ #30263)

[Joe Simmons-Talbott]

Add testcases for abs(), labs(), and llabs().  Test the bounds of the
given type, zero, and part of the full range of values for labs() and
llabs().  Test the full range for abs().

Joe Simmons-Talbott (3):
  stdlib: Add testcases for abs(). (BZ #30263)
  stdlib: Add testcases for labs(). (BZ #30263)
  stdlib: Add testcases for llabs(). (BZ #30263)

 stdlib/Makefile    |  7 +++++++
 stdlib/tst-abs.c   | 43 ++++++++++++++++++++++++++++++++++++++++
 stdlib/tst-labs.c  | 49 ++++++++++++++++++++++++++++++++++++++++++++++
 stdlib/tst-llabs.c | 49 ++++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 148 insertions(+)
 create mode 100644 stdlib/tst-abs.c
 create mode 100644 stdlib/tst-labs.c
 create mode 100644 stdlib/tst-llabs.c

-- 
2.39.2