From: "naohirot@fujitsu.com" <naohirot@fujitsu.com>
To: 'Joseph Myers' <joseph@codesourcery.com>
Cc: "libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Subject: RE: [PATCH v3] configure: Replaced obsolete AC_TRY_COMPILE
Date: Tue, 11 May 2021 01:28:25 +0000 [thread overview]
Message-ID: <TYAPR01MB60257382313834A4B950D083DF539@TYAPR01MB6025.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2105101738230.750431@digraph.polyomino.org.uk>
Hi Joseph,
Thank you for the review!
> From: Joseph Myers <joseph@codesourcery.com>
> On Mon, 10 May 2021, Naohiro Tamura wrote:
>
> > diff --git a/sysdeps/mach/hurd/configure b/sysdeps/mach/hurd/configure
> > index 4876e1f176..fd84a36df8 100644
> > --- a/sysdeps/mach/hurd/configure
> > +++ b/sysdeps/mach/hurd/configure
> > @@ -1,3 +1,41 @@
> > +
> > +
> > +# ac_fn_c_try_cpp LINENO
> > +# ----------------------
> > +# Try to preprocess conftest.$ac_ext, and return whether this succeeded.
> > +ac_fn_c_try_cpp ()
> > +{
>
> In general we try to avoid duplicating such autoconf-generated function
> definitions in sysdeps configure fragments. See the definition of
> GLIBC_PROVIDES in aclocal.m4. Maybe with a change to GLIBC_PROVIDES
> you can avoid this function definition getting added to such fragments (it looks like
> the relevant toplevel configure.ac code comes long before the sysdeps configure
> fragments are loaded).
I'll fix that.
Thanks.
Naohiro
next prev parent reply other threads:[~2021-05-11 1:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 11:59 [PATCH 1/3] Replaced obsolete AC_TRY_COMPILE to AC_COMPILE_IFELSE Naohiro Tamura
2021-02-16 13:03 ` Andreas Schwab
2021-02-16 16:38 ` Zack Weinberg
2021-02-17 1:05 ` naohirot
2021-02-17 1:17 ` [PATCH v2 " Naohiro Tamura
2021-05-10 14:07 ` [PATCH v3] configure: Replaced obsolete AC_TRY_COMPILE Naohiro Tamura
2021-05-10 17:40 ` Joseph Myers
2021-05-11 1:28 ` naohirot [this message]
2021-05-11 1:34 ` [PATCH v4] " Naohiro Tamura
2021-05-19 0:46 ` naohirot
2021-05-22 1:11 ` Mike Frysinger
2021-05-22 1:32 ` naohirot
2021-05-22 1:47 ` Mike Frysinger
2021-05-22 2:00 ` naohirot
2021-05-22 2:42 ` [PATCH v5] " Naohiro Tamura
2021-05-25 16:07 ` Carlos O'Donell
2021-06-04 0:15 ` naohirot
2021-06-04 13:15 ` Adhemerval Zanella
2021-06-07 0:02 ` naohirot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYAPR01MB60257382313834A4B950D083DF539@TYAPR01MB6025.jpnprd01.prod.outlook.com \
--to=naohirot@fujitsu.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).