public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Zack Weinberg <zackw@panix.com>
To: Naohiro Tamura <naohirot@fujitsu.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH 1/3] Replaced obsolete AC_TRY_COMPILE to AC_COMPILE_IFELSE
Date: Tue, 16 Feb 2021 11:38:31 -0500	[thread overview]
Message-ID: <CAKCAbMhKfHN_T9h2qLeBiFxvG_F9186LLAk0NJvEPa_1RVm1Dg@mail.gmail.com> (raw)
In-Reply-To: <20210216115912.213547-1-naohirot@fujitsu.com>

On Tue, Feb 16, 2021 at 7:00 AM Naohiro Tamura <naohirot@fujitsu.com> wrote:
> This patch replaced obsolete AC_TRY_COMPILE to AC_COMPILE_IFELSE.
> It has been confirmed that GNU 'autoconf' 2.69 doesn't change any
> 'configure' files and suppressed obsolete warnings.

Thanks for doing this work.

> +AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[
>  #ifndef __CET__
>  # error no CET compiler support
> -#endif],
> +#endif]])],

This, and any other check where the code is entirely preprocessor
directives, should be changed to AC_PREPROC_IFELSE for efficiency.

> -AC_TRY_COMPILE([#include <float.h>], [
> +AC_COMPILE_IFELSE([AC_LANG_PROGRAM([#include <float.h>[]], [[

Typo here: it should be

> +AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <float.h>]], [[

I believe this is the root cause of the problem Andreas pointed out.

I did not proofread the entire patch.

zw

  parent reply	other threads:[~2021-02-16 16:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16 11:59 Naohiro Tamura
2021-02-16 13:03 ` Andreas Schwab
2021-02-16 16:38 ` Zack Weinberg [this message]
2021-02-17  1:05   ` naohirot
2021-02-17  1:17 ` [PATCH v2 " Naohiro Tamura
2021-05-10 14:07   ` [PATCH v3] configure: Replaced obsolete AC_TRY_COMPILE Naohiro Tamura
2021-05-10 17:40     ` Joseph Myers
2021-05-11  1:28       ` naohirot
2021-05-11  1:34     ` [PATCH v4] " Naohiro Tamura
2021-05-19  0:46       ` naohirot
2021-05-22  1:11       ` Mike Frysinger
2021-05-22  1:32         ` naohirot
2021-05-22  1:47           ` Mike Frysinger
2021-05-22  2:00             ` naohirot
2021-05-22  2:42       ` [PATCH v5] " Naohiro Tamura
2021-05-25 16:07         ` Carlos O'Donell
2021-06-04  0:15           ` naohirot
2021-06-04 13:15         ` Adhemerval Zanella
2021-06-07  0:02           ` naohirot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKCAbMhKfHN_T9h2qLeBiFxvG_F9186LLAk0NJvEPa_1RVm1Dg@mail.gmail.com \
    --to=zackw@panix.com \
    --cc=libc-alpha@sourceware.org \
    --cc=naohirot@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).