public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "naohirot@fujitsu.com" <naohirot@fujitsu.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: "libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Subject: Re: [PATCH v4] configure: Replaced obsolete AC_TRY_COMPILE
Date: Sat, 22 May 2021 01:32:05 +0000	[thread overview]
Message-ID: <TYAPR01MB6025F8FBFF1F55E95F0D9D09DF289@TYAPR01MB6025.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <YKhaWd5r1R9hLi6o@vapier>

Hi Mike,

Thanks for the comment.

> 
> On 11 May 2021 01:34, Naohiro Tamura wrote:
> > --- a/configure.ac
> > +++ b/configure.ac
> >
> > -[AC_TRY_COMPILE([], [
> > +[AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[
> >  #ifdef _FORTIFY_SOURCE
> >  # error bogon
> > -#endif],
> > +#endif]])],
> 
> this can be AC_PREPROC_IFELSE

In case of _FORTIFY_SOURCE, it requires compiler optimize option more than -O1.

$ man  FEATURE_TEST_MACROS

   If _FORTIFY_SOURCE is set to 1, with compiler optimization level 1 (gcc -O1) and above, checks that shouldn't change the behavior  of  con‐
   forming programs are performed.  With _FORTIFY_SOURCE set to 2, some more checking is added, but some conforming programs might fail.

Thanks.
Naohiro

  reply	other threads:[~2021-05-22  1:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16 11:59 [PATCH 1/3] Replaced obsolete AC_TRY_COMPILE to AC_COMPILE_IFELSE Naohiro Tamura
2021-02-16 13:03 ` Andreas Schwab
2021-02-16 16:38 ` Zack Weinberg
2021-02-17  1:05   ` naohirot
2021-02-17  1:17 ` [PATCH v2 " Naohiro Tamura
2021-05-10 14:07   ` [PATCH v3] configure: Replaced obsolete AC_TRY_COMPILE Naohiro Tamura
2021-05-10 17:40     ` Joseph Myers
2021-05-11  1:28       ` naohirot
2021-05-11  1:34     ` [PATCH v4] " Naohiro Tamura
2021-05-19  0:46       ` naohirot
2021-05-22  1:11       ` Mike Frysinger
2021-05-22  1:32         ` naohirot [this message]
2021-05-22  1:47           ` Mike Frysinger
2021-05-22  2:00             ` naohirot
2021-05-22  2:42       ` [PATCH v5] " Naohiro Tamura
2021-05-25 16:07         ` Carlos O'Donell
2021-06-04  0:15           ` naohirot
2021-06-04 13:15         ` Adhemerval Zanella
2021-06-07  0:02           ` naohirot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYAPR01MB6025F8FBFF1F55E95F0D9D09DF289@TYAPR01MB6025.jpnprd01.prod.outlook.com \
    --to=naohirot@fujitsu.com \
    --cc=libc-alpha@sourceware.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).