Re: [PATCH v2 2/2] crypt: Remove libcrypt support

[Szabolcs Nagy <szabolcs.nagy@arm.com>]

The 10/02/2023 09:11, Adhemerval Zanella wrote:
> All the crypt related functions, cryptographic algorithms, and
> make requirements are removed,  with only the exception of md5
> implementation which is moved to locale folder since it is
> required by localedef for integrity protection (libc's
> locale-reading code does not check these, but localedef does
> generate them).
> 
> Besides thec code itself, both internal documentation and the
> manual is also adjusted.  This allows to remove both --enable-crypt
> and --enable-nss-crypt configure options.
> 
> Checked with a build for all affected ABIs.
> 
> Co-authored-by: Zack Weinberg <zack@owlfolio.org>
...
> diff --git a/stdio-common/Versions b/stdio-common/Versions
> index 4bcfc3fb41..8e1cbf8559 100644
> --- a/stdio-common/Versions
> +++ b/stdio-common/Versions
> @@ -74,7 +74,5 @@ libc {
>    GLIBC_PRIVATE {
>      # global variables
>      _itoa_lower_digits;
> -    # Used in libcrypt.
> -    __snprintf;
>    }

fyi, this means that if you copy new glibc over an old system
the old libcrypt.so.1 will stop working because of missing
__snprintf@GLIBC_PRIVATE symbol.

e.g. this breaks some of our native glibc test setups, unless
we carefully rebuild a libcrypt to be compatible with both the
new glibc and the native system (old systems don't have compat
libxcrypt packaged).

what is the recommended solution for this problem?

can we keep the __snprintf symbol around (the alias is still
there we just no longer export it from libc.so)?