* [PATCH] csu: Change start code license to have link exception
@ 2022-08-25 12:23 Szabolcs Nagy
2022-08-25 18:52 ` Carlos O'Donell
0 siblings, 1 reply; 2+ messages in thread
From: Szabolcs Nagy @ 2022-08-25 12:23 UTC (permalink / raw)
To: libc-alpha
The start code can get linked into dynamic linked executables where
LGPL would require shipping the source or linkable binaries when the
executable is distributed.
On some targets the license exception was missing in start.S (which
is compiled into crt1.o and Scrt1.o which may end up linked into PDE
and PIE binaries).
I did not review what other code may end up in executables, just
fixed the start.S license inconsistency across targets.
---
sysdeps/aarch64/start.S | 25 +++++++++++++++++++++----
sysdeps/arc/start.S | 19 ++++++++++++++++++-
sysdeps/loongarch/start.S | 20 ++++++++++++++++++--
sysdeps/or1k/start.S | 22 +++++++++++++++++++---
4 files changed, 76 insertions(+), 10 deletions(-)
diff --git a/sysdeps/aarch64/start.S b/sysdeps/aarch64/start.S
index 2fb52535ba..dddbdcdd06 100644
--- a/sysdeps/aarch64/start.S
+++ b/sysdeps/aarch64/start.S
@@ -3,9 +3,26 @@
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
- modify it under the terms of the GNU Lesser General Public License as
- published by the Free Software Foundation; either version 2.1 of the
- License, or (at your option) any later version.
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ In addition to the permissions in the GNU Lesser General Public
+ License, the Free Software Foundation gives you unlimited
+ permission to link the compiled version of this file with other
+ programs, and to distribute those programs without any restriction
+ coming from the use of this file. (The GNU Lesser General Public
+ License restrictions do apply in other respects; for example, they
+ cover modification of the file, and distribution when not linked
+ into another program.)
+
+ Note that people who make modified versions of this file are not
+ obligated to grant this special exception for their modified
+ versions; it is their choice whether to do so. The GNU Lesser
+ General Public License gives permission to release a modified
+ version without this exception; this exception also makes it
+ possible to release a modified version which carries forward this
+ exception.
The GNU C Library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ -13,7 +30,7 @@
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
- License along with the GNU C Library. If not, see
+ License along with the GNU C Library; if not, see
<https://www.gnu.org/licenses/>. */
#include <sysdep.h>
diff --git a/sysdeps/arc/start.S b/sysdeps/arc/start.S
index bf01366973..152d6e13ed 100644
--- a/sysdeps/arc/start.S
+++ b/sysdeps/arc/start.S
@@ -7,13 +7,30 @@
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
+ In addition to the permissions in the GNU Lesser General Public
+ License, the Free Software Foundation gives you unlimited
+ permission to link the compiled version of this file with other
+ programs, and to distribute those programs without any restriction
+ coming from the use of this file. (The GNU Lesser General Public
+ License restrictions do apply in other respects; for example, they
+ cover modification of the file, and distribution when not linked
+ into another program.)
+
+ Note that people who make modified versions of this file are not
+ obligated to grant this special exception for their modified
+ versions; it is their choice whether to do so. The GNU Lesser
+ General Public License gives permission to release a modified
+ version without this exception; this exception also makes it
+ possible to release a modified version which carries forward this
+ exception.
+
The GNU C Library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
- License along with the GNU C Library. If not, see
+ License along with the GNU C Library; if not, see
<https://www.gnu.org/licenses/>. */
#define __ASSEMBLY__ 1
diff --git a/sysdeps/loongarch/start.S b/sysdeps/loongarch/start.S
index bf5728b3ae..e66af16d57 100644
--- a/sysdeps/loongarch/start.S
+++ b/sysdeps/loongarch/start.S
@@ -2,19 +2,35 @@
Copyright (C) 2022 Free Software Foundation, Inc.
This file is part of the GNU C Library.
-
The GNU C Library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
+ In addition to the permissions in the GNU Lesser General Public
+ License, the Free Software Foundation gives you unlimited
+ permission to link the compiled version of this file with other
+ programs, and to distribute those programs without any restriction
+ coming from the use of this file. (The GNU Lesser General Public
+ License restrictions do apply in other respects; for example, they
+ cover modification of the file, and distribution when not linked
+ into another program.)
+
+ Note that people who make modified versions of this file are not
+ obligated to grant this special exception for their modified
+ versions; it is their choice whether to do so. The GNU Lesser
+ General Public License gives permission to release a modified
+ version without this exception; this exception also makes it
+ possible to release a modified version which carries forward this
+ exception.
+
The GNU C Library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
- License along with the GNU C Library. If not, see
+ License along with the GNU C Library; if not, see
<https://www.gnu.org/licenses/>. */
#define __ASSEMBLY__ 1
diff --git a/sysdeps/or1k/start.S b/sysdeps/or1k/start.S
index 3577fc93e8..e9cc1958ad 100644
--- a/sysdeps/or1k/start.S
+++ b/sysdeps/or1k/start.S
@@ -7,15 +7,31 @@
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
+ In addition to the permissions in the GNU Lesser General Public
+ License, the Free Software Foundation gives you unlimited
+ permission to link the compiled version of this file with other
+ programs, and to distribute those programs without any restriction
+ coming from the use of this file. (The GNU Lesser General Public
+ License restrictions do apply in other respects; for example, they
+ cover modification of the file, and distribution when not linked
+ into another program.)
+
+ Note that people who make modified versions of this file are not
+ obligated to grant this special exception for their modified
+ versions; it is their choice whether to do so. The GNU Lesser
+ General Public License gives permission to release a modified
+ version without this exception; this exception also makes it
+ possible to release a modified version which carries forward this
+ exception.
+
The GNU C Library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
- License along with the GNU C Library; if not, write to the Free
- Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
- 02111-1307 USA. */
+ License along with the GNU C Library; if not, see
+ <https://www.gnu.org/licenses/>. */
/* This is the canonical entry point, usually the first thing in the text
segment.
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] csu: Change start code license to have link exception
2022-08-25 12:23 [PATCH] csu: Change start code license to have link exception Szabolcs Nagy
@ 2022-08-25 18:52 ` Carlos O'Donell
0 siblings, 0 replies; 2+ messages in thread
From: Carlos O'Donell @ 2022-08-25 18:52 UTC (permalink / raw)
To: Szabolcs Nagy, libc-alpha
On 8/25/22 08:23, Szabolcs Nagy via Libc-alpha wrote:
> The start code can get linked into dynamic linked executables where
> LGPL would require shipping the source or linkable binaries when the
> executable is distributed.
>
> On some targets the license exception was missing in start.S (which
> is compiled into crt1.o and Scrt1.o which may end up linked into PDE
> and PIE binaries).
>
> I did not review what other code may end up in executables, just
> fixed the start.S license inconsistency across targets.
This code was always intended to be under the exception and always treated
and interpreted by the maintainers as if it had the exception.
I've reviewed this in my capacity as a glibc steward, and I see this as the
correct change to make for these files.
Please commit this to master branch.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> ---
> sysdeps/aarch64/start.S | 25 +++++++++++++++++++++----
> sysdeps/arc/start.S | 19 ++++++++++++++++++-
> sysdeps/loongarch/start.S | 20 ++++++++++++++++++--
> sysdeps/or1k/start.S | 22 +++++++++++++++++++---
> 4 files changed, 76 insertions(+), 10 deletions(-)
>
> diff --git a/sysdeps/aarch64/start.S b/sysdeps/aarch64/start.S
> index 2fb52535ba..dddbdcdd06 100644
> --- a/sysdeps/aarch64/start.S
> +++ b/sysdeps/aarch64/start.S
> @@ -3,9 +3,26 @@
> This file is part of the GNU C Library.
>
> The GNU C Library is free software; you can redistribute it and/or
> - modify it under the terms of the GNU Lesser General Public License as
> - published by the Free Software Foundation; either version 2.1 of the
> - License, or (at your option) any later version.
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + In addition to the permissions in the GNU Lesser General Public
> + License, the Free Software Foundation gives you unlimited
> + permission to link the compiled version of this file with other
> + programs, and to distribute those programs without any restriction
> + coming from the use of this file. (The GNU Lesser General Public
> + License restrictions do apply in other respects; for example, they
> + cover modification of the file, and distribution when not linked
> + into another program.)
> +
> + Note that people who make modified versions of this file are not
> + obligated to grant this special exception for their modified
> + versions; it is their choice whether to do so. The GNU Lesser
> + General Public License gives permission to release a modified
> + version without this exception; this exception also makes it
> + possible to release a modified version which carries forward this
> + exception.
>
> The GNU C Library is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> @@ -13,7 +30,7 @@
> Lesser General Public License for more details.
>
> You should have received a copy of the GNU Lesser General Public
> - License along with the GNU C Library. If not, see
> + License along with the GNU C Library; if not, see
> <https://www.gnu.org/licenses/>. */
>
> #include <sysdep.h>
> diff --git a/sysdeps/arc/start.S b/sysdeps/arc/start.S
> index bf01366973..152d6e13ed 100644
> --- a/sysdeps/arc/start.S
> +++ b/sysdeps/arc/start.S
> @@ -7,13 +7,30 @@
> License as published by the Free Software Foundation; either
> version 2.1 of the License, or (at your option) any later version.
>
> + In addition to the permissions in the GNU Lesser General Public
> + License, the Free Software Foundation gives you unlimited
> + permission to link the compiled version of this file with other
> + programs, and to distribute those programs without any restriction
> + coming from the use of this file. (The GNU Lesser General Public
> + License restrictions do apply in other respects; for example, they
> + cover modification of the file, and distribution when not linked
> + into another program.)
> +
> + Note that people who make modified versions of this file are not
> + obligated to grant this special exception for their modified
> + versions; it is their choice whether to do so. The GNU Lesser
> + General Public License gives permission to release a modified
> + version without this exception; this exception also makes it
> + possible to release a modified version which carries forward this
> + exception.
> +
> The GNU C Library is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> Lesser General Public License for more details.
>
> You should have received a copy of the GNU Lesser General Public
> - License along with the GNU C Library. If not, see
> + License along with the GNU C Library; if not, see
> <https://www.gnu.org/licenses/>. */
>
> #define __ASSEMBLY__ 1
> diff --git a/sysdeps/loongarch/start.S b/sysdeps/loongarch/start.S
> index bf5728b3ae..e66af16d57 100644
> --- a/sysdeps/loongarch/start.S
> +++ b/sysdeps/loongarch/start.S
> @@ -2,19 +2,35 @@
> Copyright (C) 2022 Free Software Foundation, Inc.
> This file is part of the GNU C Library.
>
> -
> The GNU C Library is free software; you can redistribute it and/or
> modify it under the terms of the GNU Lesser General Public
> License as published by the Free Software Foundation; either
> version 2.1 of the License, or (at your option) any later version.
>
> + In addition to the permissions in the GNU Lesser General Public
> + License, the Free Software Foundation gives you unlimited
> + permission to link the compiled version of this file with other
> + programs, and to distribute those programs without any restriction
> + coming from the use of this file. (The GNU Lesser General Public
> + License restrictions do apply in other respects; for example, they
> + cover modification of the file, and distribution when not linked
> + into another program.)
> +
> + Note that people who make modified versions of this file are not
> + obligated to grant this special exception for their modified
> + versions; it is their choice whether to do so. The GNU Lesser
> + General Public License gives permission to release a modified
> + version without this exception; this exception also makes it
> + possible to release a modified version which carries forward this
> + exception.
> +
> The GNU C Library is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> Lesser General Public License for more details.
>
> You should have received a copy of the GNU Lesser General Public
> - License along with the GNU C Library. If not, see
> + License along with the GNU C Library; if not, see
> <https://www.gnu.org/licenses/>. */
>
> #define __ASSEMBLY__ 1
> diff --git a/sysdeps/or1k/start.S b/sysdeps/or1k/start.S
> index 3577fc93e8..e9cc1958ad 100644
> --- a/sysdeps/or1k/start.S
> +++ b/sysdeps/or1k/start.S
> @@ -7,15 +7,31 @@
> License as published by the Free Software Foundation; either
> version 2.1 of the License, or (at your option) any later version.
>
> + In addition to the permissions in the GNU Lesser General Public
> + License, the Free Software Foundation gives you unlimited
> + permission to link the compiled version of this file with other
> + programs, and to distribute those programs without any restriction
> + coming from the use of this file. (The GNU Lesser General Public
> + License restrictions do apply in other respects; for example, they
> + cover modification of the file, and distribution when not linked
> + into another program.)
> +
> + Note that people who make modified versions of this file are not
> + obligated to grant this special exception for their modified
> + versions; it is their choice whether to do so. The GNU Lesser
> + General Public License gives permission to release a modified
> + version without this exception; this exception also makes it
> + possible to release a modified version which carries forward this
> + exception.
> +
> The GNU C Library is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> Lesser General Public License for more details.
>
> You should have received a copy of the GNU Lesser General Public
> - License along with the GNU C Library; if not, write to the Free
> - Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
> - 02111-1307 USA. */
> + License along with the GNU C Library; if not, see
> + <https://www.gnu.org/licenses/>. */
>
> /* This is the canonical entry point, usually the first thing in the text
> segment.
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-25 18:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-25 12:23 [PATCH] csu: Change start code license to have link exception Szabolcs Nagy
2022-08-25 18:52 ` Carlos O'Donell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).