Re: [PATCH] LoongArch: Fix ABI related macros in elf.h to keep consistent with binutils[1].

[Xi Ruoyao <xry111@xry111.site>]

On Mon, 2022-10-31 at 09:12 -0400, Carlos O'Donell wrote:
> On 10/31/22 02:34, Xi Ruoyao via Libc-alpha wrote:
> > On Mon, 2022-10-31 at 11:43 +0800, caiyinyu wrote:
> > > [1]:
> > > https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=c4a7e6b56218e1d5a858682186b542e2eae01a4a;hp=0d94a8735055432029237612a6eb9165db1ec9dd
> > > [2]:
> > > Reference: https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html#_e_flags_identifies_abi_type_and_version
> > > ---
> > >  elf/elf.h | 6 ++++--
> > >  1 file changed, 4 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/elf/elf.h b/elf/elf.h
> > > index 3f08823a30..383eb5fbff 100644
> > > --- a/elf/elf.h
> > > +++ b/elf/elf.h
> > > @@ -4093,8 +4093,10 @@ enum
> > >  #define R_NDS32_TLS_DESC       119
> > >  
> > >  /* LoongArch ELF Flags */
> > > -#define EF_LARCH_ABI           0x07
> 
> I assume this is a mask for the bits.
> 
> > > -#define EF_LARCH_ABI_LP64D     0x03
> > 
> > Does Glibc API policy allow to remove a macro definition in a public
> > header?
> 
> If a public glibc release has been made of this header then it is public ABI.
> 
> How big is the LoongArch community? You could remove these things if you wanted,
> but it is not good for existing source compatibility.
>  
> > > +#define EF_LOONGARCH_ABI_SOFT_FLOAT     0x1
> > > +#define EF_LOONGARCH_ABI_SINGLE_FLOAT   0x2
> > > +#define EF_LOONGARCH_ABI_DOUBLE_FLOAT   0x3

Hmm, is "LARCH" -> "LOONGARCH" change intentional here?

> Best practice is to keep the old macro names around.
> 
> Add the new macro names.

I agree.
-- 
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University