From: caiyinyu <caiyinyu@loongson.cn>
To: Xi Ruoyao <xry111@xry111.site>,
Carlos O'Donell <carlos@redhat.com>,
adhemerval.zanella@linaro.org
Cc: i.swmail@xen0n.name, libc-alpha@sourceware.org
Subject: Re: [PATCH] LoongArch: Fix ABI related macros in elf.h to keep consistent with binutils[1].
Date: Wed, 2 Nov 2022 14:13:05 +0800 [thread overview]
Message-ID: <b999e9a7-c06e-d96b-d6fb-32d570bb1e54@loongson.cn> (raw)
In-Reply-To: <ef2cb2c2bd5bd56b762c89b67ae610ff81e79785.camel@xry111.site>
在 2022/11/1 上午10:14, Xi Ruoyao 写道:
> On Tue, 2022-11-01 at 10:02 +0800, caiyinyu wrote:
>
>> diff --git a/elf/elf.h b/elf/elf.h
>>
>> index 3f08823a30..d51eb75a73 100644
>> --- a/elf/elf.h
>> +++ b/elf/elf.h
>> @@ -4093,8 +4093,11 @@ enum
>> #define R_NDS32_TLS_DESC 119
>>
>> /* LoongArch ELF Flags */
>> -#define EF_LARCH_ABI 0x07
>> -#define EF_LARCH_ABI_LP64D 0x03
>> +#define EF_LOONGARCH_ABI_MODIFIER_MASK 0x07
>> +#define EF_LOONGARCH_ABI_SOFT_FLOAT 0x01
>> +#define EF_LOONGARCH_ABI_SINGLE_FLOAT 0x02
>> +#define EF_LOONGARCH_ABI_DOUBLE_FLOAT 0x03
>> +#define EF_LOONGARCH_OBJABI_V1 0x40
> Again, is "LARCH" -> "LOONGARCH" change intentional? The ABI doc does
> not specified the name of these macros... And we already have R_LARCH_*
> so the difference of "LARCH" and "LOONGARCH" seems puzzling.
We will use *LARCH* to keep consistent in glibc and binutils like other
arches
and update the docs soon:
diff --git a/elf/elf.h b/elf/elf.h
index d51eb75a73..04dc2ee563 100644
--- a/elf/elf.h
+++ b/elf/elf.h
@@ -4093,11 +4093,11 @@ enum
#define R_NDS32_TLS_DESC 119
/* LoongArch ELF Flags */
-#define EF_LOONGARCH_ABI_MODIFIER_MASK 0x07
-#define EF_LOONGARCH_ABI_SOFT_FLOAT 0x01
-#define EF_LOONGARCH_ABI_SINGLE_FLOAT 0x02
-#define EF_LOONGARCH_ABI_DOUBLE_FLOAT 0x03
-#define EF_LOONGARCH_OBJABI_V1 0x40
+#define EF_LARCH_ABI_MODIFIER_MASK 0x07
+#define EF_LARCH_ABI_SOFT_FLOAT 0x01
+#define EF_LARCH_ABI_SINGLE_FLOAT 0x02
+#define EF_LARCH_ABI_DOUBLE_FLOAT 0x03
+#define EF_LARCH_OBJABI_V1 0x40
/* LoongArch specific dynamic relocations */
#define R_LARCH_NONE 0
> And is it an option to keep old names there with a warning?
>
> #define EF_LARCH_ABI_LP64D __glibc_macro_warning ("EF_LARCH_ABI_LP64D is deprecated") 0x03
>
I tend to remove it now.
next prev parent reply other threads:[~2022-11-02 6:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 3:43 caiyinyu
2022-10-31 6:34 ` Xi Ruoyao
2022-10-31 13:12 ` Carlos O'Donell
2022-11-01 2:00 ` Xi Ruoyao
2022-11-01 2:02 ` caiyinyu
2022-11-01 2:14 ` Xi Ruoyao
2022-11-02 6:13 ` caiyinyu [this message]
2022-11-02 6:19 ` WANG Xuerui
2022-11-02 10:41 ` Xi Ruoyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b999e9a7-c06e-d96b-d6fb-32d570bb1e54@loongson.cn \
--to=caiyinyu@loongson.cn \
--cc=adhemerval.zanella@linaro.org \
--cc=carlos@redhat.com \
--cc=i.swmail@xen0n.name \
--cc=libc-alpha@sourceware.org \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).