From: Carlos O'Donell <carlos@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Paul Eggert <eggert@cs.ucla.edu>,
libc-alpha@gnu.org
Subject: Re: [PATCH] cdefs.h: fix "__clang_major" typo
Date: Thu, 23 Feb 2023 13:30:55 -0500 [thread overview]
Message-ID: <a55e47f6-1c7f-7a44-69a1-bdeb03ad8038@redhat.com> (raw)
In-Reply-To: <c6bbc56a-6fd2-ec2d-6209-938645aaa599@linaro.org>
On 12/30/21 06:20, Adhemerval Zanella via Libc-alpha wrote:
>
>
> On 21/12/2021 19:13, Paul Eggert wrote:
>> * misc/sys/cdefs.h: Fix misspelling of "__clang_major__".
>
> LGTM, thanks.
>
> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Ahemerval,
In reviewing old patches to improve our SLI for patch review I noticed that
this patch is reviewed and approved but not committed. The patch still looks
correct to me.
Would you mind committing this on behalf of Paul please?
>> ---
>> misc/sys/cdefs.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/misc/sys/cdefs.h b/misc/sys/cdefs.h
>> index a05b538579..f6e1db1954 100644
>> --- a/misc/sys/cdefs.h
>> +++ b/misc/sys/cdefs.h
>> @@ -81,7 +81,7 @@
>> # define __NTH(fct) __attribute__ ((__nothrow__ __LEAF)) fct
>> # define __NTHNL(fct) __attribute__ ((__nothrow__)) fct
>> # else
>> -# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major >= 4)
>> +# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major__ >= 4)
>> # if __cplusplus >= 201103L
>> # define __THROW noexcept (true)
>> # else
>
--
Cheers,
Carlos.
next prev parent reply other threads:[~2023-02-23 18:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 22:13 Paul Eggert
2021-12-30 11:20 ` Adhemerval Zanella
2023-02-23 18:30 ` Carlos O'Donell [this message]
2023-02-27 11:23 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a55e47f6-1c7f-7a44-69a1-bdeb03ad8038@redhat.com \
--to=carlos@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=eggert@cs.ucla.edu \
--cc=libc-alpha@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).