* [PATCH] cdefs.h: fix "__clang_major" typo
@ 2021-12-21 22:13 Paul Eggert
2021-12-30 11:20 ` Adhemerval Zanella
0 siblings, 1 reply; 4+ messages in thread
From: Paul Eggert @ 2021-12-21 22:13 UTC (permalink / raw)
To: libc-alpha
* misc/sys/cdefs.h: Fix misspelling of "__clang_major__".
---
misc/sys/cdefs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/misc/sys/cdefs.h b/misc/sys/cdefs.h
index a05b538579..f6e1db1954 100644
--- a/misc/sys/cdefs.h
+++ b/misc/sys/cdefs.h
@@ -81,7 +81,7 @@
# define __NTH(fct) __attribute__ ((__nothrow__ __LEAF)) fct
# define __NTHNL(fct) __attribute__ ((__nothrow__)) fct
# else
-# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major >= 4)
+# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major__ >= 4)
# if __cplusplus >= 201103L
# define __THROW noexcept (true)
# else
--
2.32.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cdefs.h: fix "__clang_major" typo
2021-12-21 22:13 [PATCH] cdefs.h: fix "__clang_major" typo Paul Eggert
@ 2021-12-30 11:20 ` Adhemerval Zanella
2023-02-23 18:30 ` Carlos O'Donell
0 siblings, 1 reply; 4+ messages in thread
From: Adhemerval Zanella @ 2021-12-30 11:20 UTC (permalink / raw)
To: Paul Eggert, libc-alpha
On 21/12/2021 19:13, Paul Eggert wrote:
> * misc/sys/cdefs.h: Fix misspelling of "__clang_major__".
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> misc/sys/cdefs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/misc/sys/cdefs.h b/misc/sys/cdefs.h
> index a05b538579..f6e1db1954 100644
> --- a/misc/sys/cdefs.h
> +++ b/misc/sys/cdefs.h
> @@ -81,7 +81,7 @@
> # define __NTH(fct) __attribute__ ((__nothrow__ __LEAF)) fct
> # define __NTHNL(fct) __attribute__ ((__nothrow__)) fct
> # else
> -# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major >= 4)
> +# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major__ >= 4)
> # if __cplusplus >= 201103L
> # define __THROW noexcept (true)
> # else
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cdefs.h: fix "__clang_major" typo
2021-12-30 11:20 ` Adhemerval Zanella
@ 2023-02-23 18:30 ` Carlos O'Donell
2023-02-27 11:23 ` Adhemerval Zanella Netto
0 siblings, 1 reply; 4+ messages in thread
From: Carlos O'Donell @ 2023-02-23 18:30 UTC (permalink / raw)
To: Adhemerval Zanella, Paul Eggert, libc-alpha
On 12/30/21 06:20, Adhemerval Zanella via Libc-alpha wrote:
>
>
> On 21/12/2021 19:13, Paul Eggert wrote:
>> * misc/sys/cdefs.h: Fix misspelling of "__clang_major__".
>
> LGTM, thanks.
>
> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Ahemerval,
In reviewing old patches to improve our SLI for patch review I noticed that
this patch is reviewed and approved but not committed. The patch still looks
correct to me.
Would you mind committing this on behalf of Paul please?
>> ---
>> misc/sys/cdefs.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/misc/sys/cdefs.h b/misc/sys/cdefs.h
>> index a05b538579..f6e1db1954 100644
>> --- a/misc/sys/cdefs.h
>> +++ b/misc/sys/cdefs.h
>> @@ -81,7 +81,7 @@
>> # define __NTH(fct) __attribute__ ((__nothrow__ __LEAF)) fct
>> # define __NTHNL(fct) __attribute__ ((__nothrow__)) fct
>> # else
>> -# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major >= 4)
>> +# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major__ >= 4)
>> # if __cplusplus >= 201103L
>> # define __THROW noexcept (true)
>> # else
>
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cdefs.h: fix "__clang_major" typo
2023-02-23 18:30 ` Carlos O'Donell
@ 2023-02-27 11:23 ` Adhemerval Zanella Netto
0 siblings, 0 replies; 4+ messages in thread
From: Adhemerval Zanella Netto @ 2023-02-27 11:23 UTC (permalink / raw)
To: Carlos O'Donell, Paul Eggert, libc-alpha
On 23/02/23 15:30, Carlos O'Donell wrote:
> On 12/30/21 06:20, Adhemerval Zanella via Libc-alpha wrote:
>>
>>
>> On 21/12/2021 19:13, Paul Eggert wrote:
>>> * misc/sys/cdefs.h: Fix misspelling of "__clang_major__".
>>
>> LGTM, thanks.
>>
>> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
> Ahemerval,
>
> In reviewing old patches to improve our SLI for patch review I noticed that
> this patch is reviewed and approved but not committed. The patch still looks
> correct to me.
>
> Would you mind committing this on behalf of Paul please?
>
>
Done.
>>> ---
>>> misc/sys/cdefs.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/misc/sys/cdefs.h b/misc/sys/cdefs.h
>>> index a05b538579..f6e1db1954 100644
>>> --- a/misc/sys/cdefs.h
>>> +++ b/misc/sys/cdefs.h
>>> @@ -81,7 +81,7 @@
>>> # define __NTH(fct) __attribute__ ((__nothrow__ __LEAF)) fct
>>> # define __NTHNL(fct) __attribute__ ((__nothrow__)) fct
>>> # else
>>> -# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major >= 4)
>>> +# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major__ >= 4)
>>> # if __cplusplus >= 201103L
>>> # define __THROW noexcept (true)
>>> # else
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-27 11:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-21 22:13 [PATCH] cdefs.h: fix "__clang_major" typo Paul Eggert
2021-12-30 11:20 ` Adhemerval Zanella
2023-02-23 18:30 ` Carlos O'Donell
2023-02-27 11:23 ` Adhemerval Zanella Netto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).