From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org, Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Subject: Re: [PATCH] AArch64: Fix typo in sve configure check (BZ# 29394)
Date: Thu, 11 Aug 2022 13:42:39 -0300 [thread overview]
Message-ID: <af5cc0bb-ffb7-eebf-49e0-327067c92aa9@linaro.org> (raw)
In-Reply-To: <AM5PR0801MB166893E2869BF1BBFCB234BD83649@AM5PR0801MB1668.eurprd08.prod.outlook.com>
LGTM, thanks.
On 11/08/22 13:25, Wilco Dijkstra via Libc-alpha wrote:
> Fix a typo in the SVE configure check. This fixes BZ# 29394.
>
> ---
>
> diff --git a/sysdeps/aarch64/configure b/sysdeps/aarch64/configure
> index bf972122b199e1dd7ef04c58dee99ed864274174..2130f6b8f8b423fbdc97b066e9cfe2cd977aa792 100644
> --- a/sysdeps/aarch64/configure
> +++ b/sysdeps/aarch64/configure
> @@ -303,7 +303,7 @@ aarch64-variant-pcs = $libc_cv_aarch64_variant_pcs"
> # Check if asm support armv8.2-a+sve
> { $as_echo "$as_me:${as_lineno-$LINENO}: checking for SVE support in assembler" >&5
> $as_echo_n "checking for SVE support in assembler... " >&6; }
> -if ${libc_cv_asm_sve+:} false; then :
> +if ${libc_cv_aarch64_sve_asm+:} false; then :
> $as_echo_n "(cached) " >&6
> else
> cat > conftest.s <<\EOF
> @@ -321,8 +321,8 @@ else
> fi
> rm -f conftest*
> fi
> -{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_asm_sve" >&5
> -$as_echo "$libc_cv_asm_sve" >&6; }
> +{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_aarch64_sve_asm" >&5
> +$as_echo "$libc_cv_aarch64_sve_asm" >&6; }
> if test $libc_cv_aarch64_sve_asm = yes; then
> $as_echo "#define HAVE_AARCH64_SVE_ASM 1" >>confdefs.h
>
> diff --git a/sysdeps/aarch64/configure.ac b/sysdeps/aarch64/configure.ac
> index 51253d98025b6f5956575558e459d72e0763c674..85c6f765082811f5e8312eebda8d615eabcf39a1 100644
> --- a/sysdeps/aarch64/configure.ac
> +++ b/sysdeps/aarch64/configure.ac
> @@ -88,7 +88,7 @@ EOF
> LIBC_CONFIG_VAR([aarch64-variant-pcs], [$libc_cv_aarch64_variant_pcs])
>
> # Check if asm support armv8.2-a+sve
> -AC_CACHE_CHECK(for SVE support in assembler, libc_cv_asm_sve, [dnl
> +AC_CACHE_CHECK([for SVE support in assembler], [libc_cv_aarch64_sve_asm], [dnl
> cat > conftest.s <<\EOF
> ptrue p0.b
> EOF
>
next prev parent reply other threads:[~2022-08-11 16:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 16:25 Wilco Dijkstra
2022-08-11 16:42 ` Adhemerval Zanella Netto [this message]
2022-08-16 13:00 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af5cc0bb-ffb7-eebf-49e0-327067c92aa9@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=Wilco.Dijkstra@arm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).