public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] AArch64: Fix typo in sve configure check (BZ# 29394)
@ 2022-08-11 16:25 Wilco Dijkstra
  2022-08-11 16:42 ` Adhemerval Zanella Netto
  2022-08-16 13:00 ` Andreas Schwab
  0 siblings, 2 replies; 3+ messages in thread
From: Wilco Dijkstra @ 2022-08-11 16:25 UTC (permalink / raw)
  To: 'GNU C Library'

Fix a typo in the SVE configure check. This fixes BZ# 29394.

---

diff --git a/sysdeps/aarch64/configure b/sysdeps/aarch64/configure
index bf972122b199e1dd7ef04c58dee99ed864274174..2130f6b8f8b423fbdc97b066e9cfe2cd977aa792 100644
--- a/sysdeps/aarch64/configure
+++ b/sysdeps/aarch64/configure
@@ -303,7 +303,7 @@ aarch64-variant-pcs = $libc_cv_aarch64_variant_pcs"
 # Check if asm support armv8.2-a+sve
 { $as_echo "$as_me:${as_lineno-$LINENO}: checking for SVE support in assembler" >&5
 $as_echo_n "checking for SVE support in assembler... " >&6; }
-if ${libc_cv_asm_sve+:} false; then :
+if ${libc_cv_aarch64_sve_asm+:} false; then :
   $as_echo_n "(cached) " >&6
 else
   cat > conftest.s <<\EOF
@@ -321,8 +321,8 @@ else
 fi
 rm -f conftest*
 fi
-{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_asm_sve" >&5
-$as_echo "$libc_cv_asm_sve" >&6; }
+{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_aarch64_sve_asm" >&5
+$as_echo "$libc_cv_aarch64_sve_asm" >&6; }
 if test $libc_cv_aarch64_sve_asm = yes; then
   $as_echo "#define HAVE_AARCH64_SVE_ASM 1" >>confdefs.h
 
diff --git a/sysdeps/aarch64/configure.ac b/sysdeps/aarch64/configure.ac
index 51253d98025b6f5956575558e459d72e0763c674..85c6f765082811f5e8312eebda8d615eabcf39a1 100644
--- a/sysdeps/aarch64/configure.ac
+++ b/sysdeps/aarch64/configure.ac
@@ -88,7 +88,7 @@ EOF
 LIBC_CONFIG_VAR([aarch64-variant-pcs], [$libc_cv_aarch64_variant_pcs])
 
 # Check if asm support armv8.2-a+sve
-AC_CACHE_CHECK(for SVE support in assembler, libc_cv_asm_sve, [dnl
+AC_CACHE_CHECK([for SVE support in assembler], [libc_cv_aarch64_sve_asm], [dnl
 cat > conftest.s <<\EOF
         ptrue p0.b
 EOF


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] AArch64: Fix typo in sve configure check (BZ# 29394)
  2022-08-11 16:25 [PATCH] AArch64: Fix typo in sve configure check (BZ# 29394) Wilco Dijkstra
@ 2022-08-11 16:42 ` Adhemerval Zanella Netto
  2022-08-16 13:00 ` Andreas Schwab
  1 sibling, 0 replies; 3+ messages in thread
From: Adhemerval Zanella Netto @ 2022-08-11 16:42 UTC (permalink / raw)
  To: libc-alpha, Wilco Dijkstra

LGTM, thanks.

On 11/08/22 13:25, Wilco Dijkstra via Libc-alpha wrote:
> Fix a typo in the SVE configure check. This fixes BZ# 29394.
> 
> ---
> 
> diff --git a/sysdeps/aarch64/configure b/sysdeps/aarch64/configure
> index bf972122b199e1dd7ef04c58dee99ed864274174..2130f6b8f8b423fbdc97b066e9cfe2cd977aa792 100644
> --- a/sysdeps/aarch64/configure
> +++ b/sysdeps/aarch64/configure
> @@ -303,7 +303,7 @@ aarch64-variant-pcs = $libc_cv_aarch64_variant_pcs"
>  # Check if asm support armv8.2-a+sve
>  { $as_echo "$as_me:${as_lineno-$LINENO}: checking for SVE support in assembler" >&5
>  $as_echo_n "checking for SVE support in assembler... " >&6; }
> -if ${libc_cv_asm_sve+:} false; then :
> +if ${libc_cv_aarch64_sve_asm+:} false; then :
>    $as_echo_n "(cached) " >&6
>  else
>    cat > conftest.s <<\EOF
> @@ -321,8 +321,8 @@ else
>  fi
>  rm -f conftest*
>  fi
> -{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_asm_sve" >&5
> -$as_echo "$libc_cv_asm_sve" >&6; }
> +{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_aarch64_sve_asm" >&5
> +$as_echo "$libc_cv_aarch64_sve_asm" >&6; }
>  if test $libc_cv_aarch64_sve_asm = yes; then
>    $as_echo "#define HAVE_AARCH64_SVE_ASM 1" >>confdefs.h
>  
> diff --git a/sysdeps/aarch64/configure.ac b/sysdeps/aarch64/configure.ac
> index 51253d98025b6f5956575558e459d72e0763c674..85c6f765082811f5e8312eebda8d615eabcf39a1 100644
> --- a/sysdeps/aarch64/configure.ac
> +++ b/sysdeps/aarch64/configure.ac
> @@ -88,7 +88,7 @@ EOF
>  LIBC_CONFIG_VAR([aarch64-variant-pcs], [$libc_cv_aarch64_variant_pcs])
>  
>  # Check if asm support armv8.2-a+sve
> -AC_CACHE_CHECK(for SVE support in assembler, libc_cv_asm_sve, [dnl
> +AC_CACHE_CHECK([for SVE support in assembler], [libc_cv_aarch64_sve_asm], [dnl
>  cat > conftest.s <<\EOF
>          ptrue p0.b
>  EOF
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] AArch64: Fix typo in sve configure check (BZ# 29394)
  2022-08-11 16:25 [PATCH] AArch64: Fix typo in sve configure check (BZ# 29394) Wilco Dijkstra
  2022-08-11 16:42 ` Adhemerval Zanella Netto
@ 2022-08-16 13:00 ` Andreas Schwab
  1 sibling, 0 replies; 3+ messages in thread
From: Andreas Schwab @ 2022-08-16 13:00 UTC (permalink / raw)
  To: Wilco Dijkstra via Libc-alpha; +Cc: Wilco Dijkstra

On Aug 11 2022, Wilco Dijkstra via Libc-alpha wrote:

> Fix a typo in the SVE configure check. This fixes BZ# 29394.

Ok.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-08-16 13:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-11 16:25 [PATCH] AArch64: Fix typo in sve configure check (BZ# 29394) Wilco Dijkstra
2022-08-11 16:42 ` Adhemerval Zanella Netto
2022-08-16 13:00 ` Andreas Schwab

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).