From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Ying Huang <ying.huang@oss.cipunited.com>
Cc: libc-alpha@sourceware.org, yunqiang.su@oss.cipunited.com
Subject: Re: [PATCH v4] MIPS: Sync elf.h from binutils
Date: Tue, 6 Jun 2023 17:26:08 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.21.2306060830080.36323@angie.orcam.me.uk> (raw)
In-Reply-To: <48c20c02-3f77-2340-dcd0-80dd3f301512@oss.cipunited.com>
Hi Ying,
> OK. And I have a question, can I use space+tab combination when aligned?
If you mean a sequence of one or more of spaces immediately followed by
one or more tabs, than this is not allowed by the GNU Coding Standards.
> Because when I only use tab to align, it occurs:
>
> Vim open file shows alignment, but git diff show not alignment.
Note that the leading plus/minus/space character in a unidiff will affect
how columns are aligned where tabs are used and is sometimes a cause for
confusion, especially when hand-editing patches. Just ignore that. It's
the formatting of the actual file that matters.
NB I have:
core.whitespace=indent-with-non-tab,space-before-tab,trailing-space
set in my git configuration for GNU toolchain repos, which helps identify
some of these issues. You may still have to double-check your result, as
these automatic checks are not completely fool-proof.
HTH,
Maciej
next prev parent reply other threads:[~2023-06-06 16:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 8:08 Ying Huang
2023-06-04 17:02 ` Maciej W. Rozycki
2023-06-06 2:34 ` Ying Huang
2023-06-06 16:26 ` Maciej W. Rozycki [this message]
2023-08-09 1:46 ` Ying Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2306060830080.36323@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=libc-alpha@sourceware.org \
--cc=ying.huang@oss.cipunited.com \
--cc=yunqiang.su@oss.cipunited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).