public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "Ying Huang" <ying.huang@oss.cipunited.com>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: <libc-alpha@sourceware.org>, <yunqiang.su@oss.cipunited.com>
Subject: Re: [PATCH v4] MIPS: Sync elf.h from binutils
Date: Wed, 9 Aug 2023 09:46:15 +0800	[thread overview]
Message-ID: <2be0ad4a-e341-2ab0-acee-7090fe9efda1@oss.cipunited.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2306040036090.36323@angie.orcam.me.uk>

[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]

Hi Maciej,

>> @@ -1703,6 +1713,35 @@ typedef struct
>>  #define EF_MIPS_ARCH_64		0x60000000 /* MIPS64 code.  */
>>  #define EF_MIPS_ARCH_32R2	0x70000000 /* MIPS32r2 code.  */
>>  #define EF_MIPS_ARCH_64R2	0x80000000 /* MIPS64r2 code.  */
>> +#define E_MIPS_ARCH_32R6	0x90000000 /* -mips32r6 code.  */
>> +#define E_MIPS_ARCH_64R6	0xa0000000 /* -mips64r6 code.  */
>  I think all new additions are supposed to start with EF_ rather than E_.  
> IIUC the existence of E_ macros has something to do with the old SVR4 ABI 
> registry maintained by SCO long ago: you could only add new EF_ macros 
> once they've been registered with SCO (someone please correct me if I'm 
> wrong).
>
>  Also I think the new comments will best be spelt MIPS32r6/MIPS64r6 rather 
> than -mips32r6/-mips64r6 for consistency with MIPS32r2/MIPS64r2 above.
>
Because we did not plan to change binutils E_* to EF_* and hope to sync them to libc, so I would only change related comments.

Thanks for all your suggestions.

Ying

      parent reply	other threads:[~2023-08-09  1:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-02  8:08 Ying Huang
2023-06-04 17:02 ` Maciej W. Rozycki
2023-06-06  2:34   ` Ying Huang
2023-06-06 16:26     ` Maciej W. Rozycki
2023-08-09  1:46   ` Ying Huang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2be0ad4a-e341-2ab0-acee-7090fe9efda1@oss.cipunited.com \
    --to=ying.huang@oss.cipunited.com \
    --cc=libc-alpha@sourceware.org \
    --cc=macro@orcam.me.uk \
    --cc=yunqiang.su@oss.cipunited.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).