From: Joseph Myers <joseph@codesourcery.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org, "Alexandra Hájková" <ahajkova@redhat.com>
Subject: Re: [PATCH] Add valgrind smoke test
Date: Mon, 28 Jun 2021 18:33:03 +0000 [thread overview]
Message-ID: <alpine.DEB.2.22.394.2106281825300.220739@digraph.polyomino.org.uk> (raw)
In-Reply-To: <878s2uz91r.fsf@oldenburg.str.redhat.com>
On Mon, 28 Jun 2021, Florian Weimer via Libc-alpha wrote:
> Would it be okay to run these tests only if $(run-built-tests) is yes,
> $(cross-compiling) is no, and configure had found a valgrind binary?
We've got rid of the vast bulk of $(cross-compiling) conditionals that
actually change what's built, tested or installed; I don't like the idea
of adding more, when we already have an example of a test that deals with
checking whether a given command (gdb in that case) is available before
running it.
(And you can't avoid the issue of /usr/bin/true possibly not existing or
having the wrong ABI in any case.)
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2021-06-28 18:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 12:15 Alexandra Hájková
2021-05-24 14:28 ` Carlos O'Donell
2021-05-24 19:28 ` Joseph Myers
2021-06-28 8:29 ` Florian Weimer
2021-06-28 18:33 ` Joseph Myers [this message]
[not found] ` <CAJVr-EMvXXXx63a0Ht9iAxo-iV9fMpuo16c7ySqOukN10tpAVA@mail.gmail.com>
2021-07-02 13:18 ` Fwd: " Alexandra Petlanova Hajkova
2021-07-05 20:28 ` Joseph Myers
2021-12-06 14:40 Alexandra Hájková
2021-12-07 11:56 ` Mark Wielaard
2021-12-07 20:32 ` DJ Delorie
2021-12-07 20:58 ` Florian Weimer
2021-12-07 21:10 ` DJ Delorie
2021-12-10 12:56 ` Mark Wielaard
2021-12-10 13:07 ` Florian Weimer
2021-12-10 19:15 ` DJ Delorie
2021-12-13 12:55 ` Mark Wielaard
2021-12-17 18:26 ` Alexandra Hájková
2021-12-17 21:07 ` DJ Delorie
2021-12-20 11:31 ` Alexandra Petlanova Hajkova
2021-12-20 11:37 ` Alexandra Hájková
2022-01-10 12:13 ` Mark Wielaard
2022-01-10 12:38 ` Adhemerval Zanella
2022-01-12 17:15 ` Alexandra Hájková
2022-01-20 19:35 ` Alexandra Hájková
2022-01-24 18:34 ` Joseph Myers
2022-01-26 17:46 ` Joseph Myers
2022-01-26 17:59 ` Mark Wielaard
2022-01-26 18:40 ` Joseph Myers
2022-01-26 19:23 ` Mark Wielaard
2022-01-20 21:29 ` DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2106281825300.220739@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=ahajkova@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).