Re: [PATCH] Add valgrind smoke test

[Mark Wielaard <mark@klomp.org>]

[-- Attachment #1: Type: text/plain, Size: 628 bytes --]

Hi Joseph,

On Mon, 2022-01-24 at 18:34 +0000, Joseph Myers wrote:
> I'm seeing
> 
> FAIL: elf/tst-valgrind-smoke
> 
> for the x86_64 configurations when running build-many-glibcs.py (and 
> UNSUPPORTED for other architectures).  No execution tests of the newly 
> built glibc should be run at all unless
> 
> ifeq ($(run-built-tests),yes)
> 
> but I don't see any such conditional around the
> 
> tests-special += $(objpfx)tst-valgrind-smoke.out
> 
> that causes this test to be run.

If your analysis is correct then the attached patch should solve the
issue. Could you try that out?

Thanks,

Mark


[-- Attachment #2: 0001-Guard-tst-valgrind-smoke.out-with-run-built-tests.patch --]
[-- Type: text/x-patch, Size: 871 bytes --]

From cc4798c2bf6acfb9e580fab6e4bad469f600e212 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Wed, 26 Jan 2022 18:57:29 +0100
Subject: [PATCH] Guard tst-valgrind-smoke.out with run-built-tests

Prevent tst-valgrind-smoke from running when run-built-tests is not yes.
---
 elf/Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/elf/Makefile b/elf/Makefile
index daafb5cf12..775c755291 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -530,7 +530,9 @@ endif
 endif
 endif
 
+ifeq ($(run-built-tests),yes)
 tests-special += $(objpfx)tst-valgrind-smoke.out
+endif
 $(objpfx)tst-valgrind-smoke.out: tst-valgrind-smoke.sh $(objpfx)ld.so $(objpfx)valgrind-test
 	$(SHELL) $< $(objpfx)ld.so  $(rtlddir)/$(rtld-installed-name) '$(test-wrapper-env)' \
 		'$(run-program-env)' '$(rpath-link)' $(objpfx)valgrind-test > $@; $(evaluate-test)
-- 
2.34.1