* [PATCH] malloc: Run tst-malloc-stats-cancellation via test-driver.c
@ 2021-04-06 22:39 Arjun Shankar
2021-04-07 0:21 ` Carlos O'Donell
0 siblings, 1 reply; 2+ messages in thread
From: Arjun Shankar @ 2021-04-06 22:39 UTC (permalink / raw)
To: libc-alpha
From: Arjun Shankar <arjun@redhat.com>
This allows the test to time out in case it hangs.
---
I ran into an instance of this test hanging when building glibc on Fedora
Rawhide for armv7hl. I am still investigating the cause of that but, in
the meanwhile, this change is still worth making.
malloc/tst-malloc-stats-cancellation.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/malloc/tst-malloc-stats-cancellation.c b/malloc/tst-malloc-stats-cancellation.c
index 9a8f475830..725cad6498 100644
--- a/malloc/tst-malloc-stats-cancellation.c
+++ b/malloc/tst-malloc-stats-cancellation.c
@@ -91,8 +91,8 @@ buffer_threadproc (void *argp)
}
-int
-main (void)
+static int
+do_test (void)
{
int result = 0, err, real_stderr_fd, bufpipe[2];
pthread_t t_thr, b_thr;
@@ -214,3 +214,5 @@ main (void)
}
return result;
}
+
+#include <support/test-driver.c>
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] malloc: Run tst-malloc-stats-cancellation via test-driver.c
2021-04-06 22:39 [PATCH] malloc: Run tst-malloc-stats-cancellation via test-driver.c Arjun Shankar
@ 2021-04-07 0:21 ` Carlos O'Donell
0 siblings, 0 replies; 2+ messages in thread
From: Carlos O'Donell @ 2021-04-07 0:21 UTC (permalink / raw)
To: Arjun Shankar, libc-alpha
On 4/6/21 6:39 PM, Arjun Shankar wrote:
> From: Arjun Shankar <arjun@redhat.com>
>
> This allows the test to time out in case it hangs.
> ---
> I ran into an instance of this test hanging when building glibc on Fedora
> Rawhide for armv7hl. I am still investigating the cause of that but, in
> the meanwhile, this change is still worth making.
>
LGTM.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> malloc/tst-malloc-stats-cancellation.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/malloc/tst-malloc-stats-cancellation.c b/malloc/tst-malloc-stats-cancellation.c
> index 9a8f475830..725cad6498 100644
> --- a/malloc/tst-malloc-stats-cancellation.c
> +++ b/malloc/tst-malloc-stats-cancellation.c
> @@ -91,8 +91,8 @@ buffer_threadproc (void *argp)
> }
>
>
> -int
> -main (void)
> +static int
> +do_test (void)
> {
> int result = 0, err, real_stderr_fd, bufpipe[2];
> pthread_t t_thr, b_thr;
> @@ -214,3 +214,5 @@ main (void)
> }
> return result;
> }
> +
> +#include <support/test-driver.c>
>
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-07 0:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-06 22:39 [PATCH] malloc: Run tst-malloc-stats-cancellation via test-driver.c Arjun Shankar
2021-04-07 0:21 ` Carlos O'Donell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).