From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Aurelien Jarno <aurelien@aurel32.net>, libc-alpha@sourceware.org
Subject: Re: [PATCH v2] linux: Drop useless include from fstatat.c
Date: Wed, 2 Nov 2022 14:18:43 -0300 [thread overview]
Message-ID: <ca4a880e-de2c-8ce0-ed4d-46b4dce922ee@linaro.org> (raw)
In-Reply-To: <20221101213608.22458-1-aurelien@aurel32.net>
On 01/11/22 18:36, Aurelien Jarno wrote:
> It is a left-over from previous refactorings.
LGTM, thanks.
Reviewed by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> sysdeps/unix/sysv/linux/fstatat.c | 2 --
> 1 file changed, 2 deletions(-)
>
> Sorry, I failed to properly test v1, we need to include <kernel_stat.h>
> to get XSTAT_IS_XSTAT64 (which is not the case on the MIPSn64 patch).
>
> diff --git a/sysdeps/unix/sysv/linux/fstatat.c b/sysdeps/unix/sysv/linux/fstatat.c
> index 055fb4762e..8926eed244 100644
> --- a/sysdeps/unix/sysv/linux/fstatat.c
> +++ b/sysdeps/unix/sysv/linux/fstatat.c
> @@ -21,8 +21,6 @@
> #include <sysdep.h>
>
> #if !XSTAT_IS_XSTAT64
> -# include <kstat_cp.h>
> -
> int
> __fstatat (int fd, const char *file, struct stat *buf, int flag)
> {
prev parent reply other threads:[~2022-11-02 17:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 21:36 Aurelien Jarno
2022-11-02 17:18 ` Adhemerval Zanella Netto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca4a880e-de2c-8ce0-ed4d-46b4dce922ee@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=aurelien@aurel32.net \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).