* [PATCH v2] linux: Drop useless include from fstatat.c
@ 2022-11-01 21:36 Aurelien Jarno
2022-11-02 17:18 ` Adhemerval Zanella Netto
0 siblings, 1 reply; 2+ messages in thread
From: Aurelien Jarno @ 2022-11-01 21:36 UTC (permalink / raw)
To: libc-alpha; +Cc: Adhemerval Zanella Netto, Aurelien Jarno
It is a left-over from previous refactorings.
---
sysdeps/unix/sysv/linux/fstatat.c | 2 --
1 file changed, 2 deletions(-)
Sorry, I failed to properly test v1, we need to include <kernel_stat.h>
to get XSTAT_IS_XSTAT64 (which is not the case on the MIPSn64 patch).
diff --git a/sysdeps/unix/sysv/linux/fstatat.c b/sysdeps/unix/sysv/linux/fstatat.c
index 055fb4762e..8926eed244 100644
--- a/sysdeps/unix/sysv/linux/fstatat.c
+++ b/sysdeps/unix/sysv/linux/fstatat.c
@@ -21,8 +21,6 @@
#include <sysdep.h>
#if !XSTAT_IS_XSTAT64
-# include <kstat_cp.h>
-
int
__fstatat (int fd, const char *file, struct stat *buf, int flag)
{
--
2.35.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] linux: Drop useless include from fstatat.c
2022-11-01 21:36 [PATCH v2] linux: Drop useless include from fstatat.c Aurelien Jarno
@ 2022-11-02 17:18 ` Adhemerval Zanella Netto
0 siblings, 0 replies; 2+ messages in thread
From: Adhemerval Zanella Netto @ 2022-11-02 17:18 UTC (permalink / raw)
To: Aurelien Jarno, libc-alpha
On 01/11/22 18:36, Aurelien Jarno wrote:
> It is a left-over from previous refactorings.
LGTM, thanks.
Reviewed by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> sysdeps/unix/sysv/linux/fstatat.c | 2 --
> 1 file changed, 2 deletions(-)
>
> Sorry, I failed to properly test v1, we need to include <kernel_stat.h>
> to get XSTAT_IS_XSTAT64 (which is not the case on the MIPSn64 patch).
>
> diff --git a/sysdeps/unix/sysv/linux/fstatat.c b/sysdeps/unix/sysv/linux/fstatat.c
> index 055fb4762e..8926eed244 100644
> --- a/sysdeps/unix/sysv/linux/fstatat.c
> +++ b/sysdeps/unix/sysv/linux/fstatat.c
> @@ -21,8 +21,6 @@
> #include <sysdep.h>
>
> #if !XSTAT_IS_XSTAT64
> -# include <kstat_cp.h>
> -
> int
> __fstatat (int fd, const char *file, struct stat *buf, int flag)
> {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-02 17:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-01 21:36 [PATCH v2] linux: Drop useless include from fstatat.c Aurelien Jarno
2022-11-02 17:18 ` Adhemerval Zanella Netto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).