public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH] scripts/dso-ordering-test.py: Fix C&P error in * callrefs processing
Date: Fri, 18 Mar 2022 13:56:58 -0300	[thread overview]
Message-ID: <cd049dab-32f8-9c9e-4037-94c7f8688fdf@linaro.org> (raw)
In-Reply-To: <877d9377an.fsf@oldenburg.str.redhat.com>



On 09/03/2022 07:24, Florian Weimer via Libc-alpha wrote:
> The elf/dso-sort-tests-src subdirectory is not changed by this commit,
> so it seems that the cut-and-paste error was not material.
> 
> This was reported by some downstream static analysis tool.

LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

> 
> ---
>  scripts/dso-ordering-test.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/dso-ordering-test.py b/scripts/dso-ordering-test.py
> index 0b526aff45..2dd6bfda18 100644
> --- a/scripts/dso-ordering-test.py
> +++ b/scripts/dso-ordering-test.py
> @@ -551,17 +551,17 @@ def process_testcase(t):
>          if obj in t.deps:
>              deps = t.deps[obj]
>              if '*' in deps:
> -                t.deps[obj].remove('*')
> +                deps.remove('*')
>                  t.add_deps([obj], non_dep_tgt_objs)
>          if obj in t.callrefs:
>              deps = t.callrefs[obj]
>              if '*' in deps:
> -                t.deps[obj].remove('*')
> +                deps.remove('*')
>                  t.add_callrefs([obj], non_dep_tgt_objs)
>      if "#" in t.deps:
>          deps = t.deps["#"]
>          if '*' in deps:
> -            t.deps["#"].remove('*')
> +            deps.remove('*')
>              t.add_deps(["#"], non_dep_tgt_objs)
>  
>      # If no main program was specified in dependency description, make a
> 

      reply	other threads:[~2022-03-18 16:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-09 10:24 Florian Weimer
2022-03-18 16:56 ` Adhemerval Zanella [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cd049dab-32f8-9c9e-4037-94c7f8688fdf@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).