* [PATCH] scripts/dso-ordering-test.py: Fix C&P error in * callrefs processing
@ 2022-03-09 10:24 Florian Weimer
2022-03-18 16:56 ` Adhemerval Zanella
0 siblings, 1 reply; 2+ messages in thread
From: Florian Weimer @ 2022-03-09 10:24 UTC (permalink / raw)
To: libc-alpha
The elf/dso-sort-tests-src subdirectory is not changed by this commit,
so it seems that the cut-and-paste error was not material.
This was reported by some downstream static analysis tool.
---
scripts/dso-ordering-test.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/dso-ordering-test.py b/scripts/dso-ordering-test.py
index 0b526aff45..2dd6bfda18 100644
--- a/scripts/dso-ordering-test.py
+++ b/scripts/dso-ordering-test.py
@@ -551,17 +551,17 @@ def process_testcase(t):
if obj in t.deps:
deps = t.deps[obj]
if '*' in deps:
- t.deps[obj].remove('*')
+ deps.remove('*')
t.add_deps([obj], non_dep_tgt_objs)
if obj in t.callrefs:
deps = t.callrefs[obj]
if '*' in deps:
- t.deps[obj].remove('*')
+ deps.remove('*')
t.add_callrefs([obj], non_dep_tgt_objs)
if "#" in t.deps:
deps = t.deps["#"]
if '*' in deps:
- t.deps["#"].remove('*')
+ deps.remove('*')
t.add_deps(["#"], non_dep_tgt_objs)
# If no main program was specified in dependency description, make a
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] scripts/dso-ordering-test.py: Fix C&P error in * callrefs processing
2022-03-09 10:24 [PATCH] scripts/dso-ordering-test.py: Fix C&P error in * callrefs processing Florian Weimer
@ 2022-03-18 16:56 ` Adhemerval Zanella
0 siblings, 0 replies; 2+ messages in thread
From: Adhemerval Zanella @ 2022-03-18 16:56 UTC (permalink / raw)
To: Florian Weimer, libc-alpha
On 09/03/2022 07:24, Florian Weimer via Libc-alpha wrote:
> The elf/dso-sort-tests-src subdirectory is not changed by this commit,
> so it seems that the cut-and-paste error was not material.
>
> This was reported by some downstream static analysis tool.
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
> ---
> scripts/dso-ordering-test.py | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/dso-ordering-test.py b/scripts/dso-ordering-test.py
> index 0b526aff45..2dd6bfda18 100644
> --- a/scripts/dso-ordering-test.py
> +++ b/scripts/dso-ordering-test.py
> @@ -551,17 +551,17 @@ def process_testcase(t):
> if obj in t.deps:
> deps = t.deps[obj]
> if '*' in deps:
> - t.deps[obj].remove('*')
> + deps.remove('*')
> t.add_deps([obj], non_dep_tgt_objs)
> if obj in t.callrefs:
> deps = t.callrefs[obj]
> if '*' in deps:
> - t.deps[obj].remove('*')
> + deps.remove('*')
> t.add_callrefs([obj], non_dep_tgt_objs)
> if "#" in t.deps:
> deps = t.deps["#"]
> if '*' in deps:
> - t.deps["#"].remove('*')
> + deps.remove('*')
> t.add_deps(["#"], non_dep_tgt_objs)
>
> # If no main program was specified in dependency description, make a
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-18 16:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-09 10:24 [PATCH] scripts/dso-ordering-test.py: Fix C&P error in * callrefs processing Florian Weimer
2022-03-18 16:56 ` Adhemerval Zanella
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).