Re: [PATCH v6 12/20] elf: Do not fail for failed dlmopen on audit modules (BZ #28061)

[Adhemerval Zanella <adhemerval.zanella@linaro.org>]

On 18/12/2021 15:59, Florian Weimer wrote:
> * Adhemerval Zanella:
> 
>> The dl_main() sets the LM_ID_BASE to RT_ADD just before starting to
>> add load new shared objects.  The state is set to R_CONSISTENT just
>> after all objects are loaded.
>>
>> However if a audit modules tries to dlmopen() an inexistent module,
>> the _dl_open() will assert that the namespace is in an inconsistent
>> state.
>>
>> This is different than dlopen(), since first it will not use
>> LM_ID_BASE and second _dl_map_object_from_fd() is the sole responsible
>> to set and reset the r_state value.
>>
>> So the assert() on _dl_open() can not really be seen if the state is
>> consistent, since _dt_main() resets it.  This patch removes the assert.
> 
> See previous comments about ().

Ack, I removed all '()'.

> 
>> diff --git a/elf/dl-open.c b/elf/dl-open.c
>> index e2f2e713e7..4f4d72e325 100644
>> --- a/elf/dl-open.c
>> +++ b/elf/dl-open.c
>> @@ -914,8 +914,6 @@ no more namespaces available for dlmopen()"));
>>  	     the flag here.  */
>>  	}
>>  
>> -      assert (_dl_debug_update (args.nsid)->r_state == RT_CONSISTENT);
>> -
> 
> 
> _dl_debug_update has already been called for its side effect above, so
> deleting the line is fine.
> 
> Reviewed-by: Florian Weimer <fweimer@redhat.com>
> 
> Thanks,
> Florian
>