public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>,
	Adhemerval Zanella <adhemerval.zanella@linaro.org>,
	 John Mellor-Crummey <johnmc@rice.edu>
Subject: Re: [PATCH v6 01/20] elf: Suppress audit calls when a (new) namespace is empty (BZ #28062)
Date: Tue, 16 Nov 2021 14:48:07 +0100	[thread overview]
Message-ID: <87h7ccciug.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <877dd8uscm.fsf@igel.home> (Andreas Schwab's message of "Tue, 16 Nov 2021 14:45:29 +0100")

* Andreas Schwab:

> On Nov 16 2021, Adhemerval Zanella via Libc-alpha wrote:
>
>> +      /* Auditing checkpoint: we are going to add new objects.  Since this
>> +         is called after _dl_add_to_namespace_list() the namespace is
>
> Not a function call here.

I've stopped pointing those out in patch reviews.  Is this GNU
convention really useful?  If there is no other markup, it often
increases readability, particular for identifiers that are also bona
fide English words, such as read and close.

Thanks,
Florian


  reply	other threads:[~2021-11-16 13:48 UTC|newest]

Thread overview: 89+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-15 18:37 [PATCH v6 00/20] Multiple rtld-audit fixes Adhemerval Zanella
2021-11-15 18:37 ` [PATCH v6 01/20] elf: Suppress audit calls when a (new) namespace is empty (BZ #28062) Adhemerval Zanella
2021-11-15 19:01   ` Florian Weimer
2021-11-16 13:14     ` Adhemerval Zanella
2021-11-16 13:15       ` Florian Weimer
2021-11-16 13:45       ` Andreas Schwab
2021-11-16 13:48         ` Florian Weimer [this message]
2021-11-16 14:16           ` Andreas Schwab
2021-11-18 19:58             ` Adhemerval Zanella
2021-11-15 18:37 ` [PATCH v6 02/20] elf: Add _dl_audit_objopen Adhemerval Zanella
2021-12-10 12:40   ` Florian Weimer
2021-12-10 12:48     ` Florian Weimer
2021-12-10 13:45       ` Adhemerval Zanella
2021-12-10 14:11         ` Adhemerval Zanella
2021-12-10 14:15           ` Florian Weimer
2021-12-10 14:41             ` Adhemerval Zanella
2021-11-15 18:37 ` [PATCH v6 03/20] elf: Add _dl_audit_activity_map and _dl_audit_activity_nsid Adhemerval Zanella
2021-12-10 13:54   ` Florian Weimer
2021-12-10 14:58     ` Adhemerval Zanella
2021-11-15 18:37 ` [PATCH v6 04/20] elf: Add _dl_audit_objsearch Adhemerval Zanella
2021-12-17 12:21   ` Florian Weimer
2021-12-17 16:09     ` Adhemerval Zanella
2021-12-17 16:12       ` Florian Weimer
2021-12-17 16:33         ` Adhemerval Zanella
2021-11-15 18:37 ` [PATCH v6 05/20] elf: Add _dl_audit_objclose Adhemerval Zanella
2021-12-17 16:29   ` Florian Weimer
2021-12-17 16:39     ` Adhemerval Zanella
2021-11-15 18:37 ` [PATCH v6 06/20] elf: Add _dl_audit_symbind_alt and _dl_audit_symbind Adhemerval Zanella
2021-12-17 16:50   ` Florian Weimer
2021-12-17 18:46     ` Adhemerval Zanella
2021-11-15 18:37 ` [PATCH v6 07/20] elf: Add _dl_audit_preinit Adhemerval Zanella
2021-12-17 17:13   ` Florian Weimer
2021-12-17 18:54     ` Adhemerval Zanella
2021-11-15 18:37 ` [PATCH v6 08/20] elf: Add _dl_audit_pltenter Adhemerval Zanella
2021-12-17 17:21   ` Florian Weimer
2021-11-15 18:37 ` [PATCH v6 09/20] elf: Add _dl_audit_pltexit Adhemerval Zanella
2021-12-17 17:43   ` Florian Weimer
2021-12-17 19:02     ` Adhemerval Zanella
2021-11-15 18:37 ` [PATCH v6 10/20] elf: Avoid unnecessary slowdown from profiling with audit (BZ#15533) Adhemerval Zanella
2021-12-18 18:45   ` Florian Weimer
2021-12-20 12:10     ` Adhemerval Zanella
2021-11-15 18:37 ` [PATCH v6 11/20] elf: Add audit tests for modules with TLSDESC Adhemerval Zanella
2021-12-18 18:53   ` Florian Weimer
2021-12-20 12:23     ` Adhemerval Zanella
2021-11-15 18:37 ` [PATCH v6 12/20] elf: Do not fail for failed dlmopen on audit modules (BZ #28061) Adhemerval Zanella
2021-12-18 18:59   ` Florian Weimer
2021-12-20 12:24     ` Adhemerval Zanella
2021-11-15 18:37 ` [PATCH v6 13/20] elf: Fix initial-exec TLS access on audit modules (BZ #28096) Adhemerval Zanella
2021-12-18 18:01   ` Florian Weimer
2021-12-20 13:25     ` Adhemerval Zanella
2021-11-15 18:37 ` [PATCH v6 14/20] elf: Issue audit la_objopen() for vDSO Adhemerval Zanella
2021-12-18 20:00   ` Florian Weimer
2021-12-20 12:50     ` Adhemerval Zanella
2021-12-20 13:18       ` Florian Weimer
2021-11-15 18:37 ` [PATCH v6 15/20] elf: Run constructors if executable has a soname of a dependency Adhemerval Zanella
2021-12-18 20:08   ` Florian Weimer
2021-12-20 16:49     ` Adhemerval Zanella
2021-12-20 16:52       ` Florian Weimer
2021-12-20 16:55         ` Adhemerval Zanella
2021-11-15 18:37 ` [PATCH v6 16/20] elf: Add main application on main_map l_name Adhemerval Zanella
2021-12-20 13:32   ` Florian Weimer
2021-12-20 18:04     ` Adhemerval Zanella
2021-11-15 18:37 ` [PATCH v6 17/20] elf: Add la_activity during application exit Adhemerval Zanella
2021-12-20 13:34   ` Florian Weimer
2021-12-20 19:46     ` Adhemerval Zanella
2021-11-15 18:37 ` [PATCH v6 18/20] elf: Issue la_symbind() for bind-now (BZ #23734) Adhemerval Zanella
2021-12-20 19:18   ` Florian Weimer
2021-12-20 20:43     ` Adhemerval Zanella
2021-12-20 21:04       ` Florian Weimer
2021-12-20 21:09         ` Adhemerval Zanella
2021-11-15 18:37 ` [PATCH v6 19/20] elf: Fix runtime linker auditing on aarch64 (BZ #26643) Adhemerval Zanella
2021-12-20 21:32   ` Florian Weimer
2021-12-21 14:33     ` Adhemerval Zanella
2021-12-21 14:44       ` Florian Weimer
2021-12-21 14:48         ` Adhemerval Zanella
2021-12-21 14:54           ` Florian Weimer
2021-12-21 17:03             ` Adhemerval Zanella
2021-12-21 17:22               ` Florian Weimer
2021-12-21 17:38                 ` Adhemerval Zanella
2021-12-21 18:11                   ` Florian Weimer
2021-12-21 18:19                     ` Adhemerval Zanella
2021-12-20 21:34   ` Florian Weimer
2021-12-21 17:47   ` Szabolcs Nagy
2021-12-21 17:49     ` Adhemerval Zanella
2021-11-15 18:37 ` [PATCH v6 20/20] elf: Add SVE support for aarch64 rtld-audit Adhemerval Zanella
2021-12-21 14:27   ` Florian Weimer
2021-12-21 14:37     ` Adhemerval Zanella
2021-12-21 16:45     ` Szabolcs Nagy
2021-12-21 17:08       ` Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7ccciug.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=johnmc@rice.edu \
    --cc=libc-alpha@sourceware.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).