Re: [PATCH v3] RISC-V: Enable static-pie.

[Andreas Schwab <schwab@suse.de>]

On Jan 02 2024, yanzhang.wang@intel.com wrote:

> diff --git a/sysdeps/riscv/dl-machine.h b/sysdeps/riscv/dl-machine.h
> index ffb8c4aaa0..0cbb476c05 100644
> --- a/sysdeps/riscv/dl-machine.h
> +++ b/sysdeps/riscv/dl-machine.h
> @@ -348,7 +348,7 @@ elf_machine_runtime_setup (struct link_map *l, struct r_scope_elem *scope[],
>        gotplt[1] = (ElfW(Addr)) l;
>      }
>  
> -  if (l->l_type == lt_executable)
> +  if (l->l_type == lt_executable && l->l_scope != NULL)

This is not the right way to test for static PIE, it tries to access a
non-relocated non-zero pointer.  The mold linker, when producing
relative relocations, puts the addend both in the relocation addend and
the relocated field, which is perfectly valid to do, so this is non-zero
here.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."