* [PATCH 1/1] malloc: remove redundant check of unsorted bin corruption
[not found] <CGME20210408092938epcas5p4c8c403c2aa26d19185e1be641ce293aa@epcas5p4.samsung.com>
@ 2021-04-08 9:29 ` Ayush Mittal
2023-02-22 22:05 ` DJ Delorie
0 siblings, 1 reply; 2+ messages in thread
From: Ayush Mittal @ 2021-04-08 9:29 UTC (permalink / raw)
To: libc-alpha; +Cc: maninder1.s, a.sahrawat, akhilesh.k, Ayush Mittal
* malloc/malloc.c (_int_malloc): remove redundant check of
unsorted bin corruption
With commit "b90ddd08f6dd688e651df9ee89ca3a69ff88cd0c"
(malloc: Additional checks for unsorted bin integrity),
same check of (bck->fd != victim) is added before checking of unsorted
chunk corruption, which was added in "bdc3009b8ff0effdbbfb05eb6b10966753cbf9b8"
(Added check before removing from unsorted list).
..
3773 if (__glibc_unlikely (bck->fd != victim)
3774 || __glibc_unlikely (victim->fd != unsorted_chunks (av)))
3775 malloc_printerr ("malloc(): unsorted double linked list corrupted");
..
..
3815 /* remove from unsorted list */
3816 if (__glibc_unlikely (bck->fd != victim))
3817 malloc_printerr ("malloc(): corrupted unsorted chunks 3");
3818 unsorted_chunks (av)->bk = bck;
..
So this extra check can be removed.
Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Signed-off-by: Ayush Mittal <ayush.m@samsung.com>
---
malloc/malloc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/malloc/malloc.c b/malloc/malloc.c
index 5b87bdb081..77bde442ab 100644
--- a/malloc/malloc.c
+++ b/malloc/malloc.c
@@ -3813,8 +3813,6 @@ _int_malloc (mstate av, size_t bytes)
}
/* remove from unsorted list */
- if (__glibc_unlikely (bck->fd != victim))
- malloc_printerr ("malloc(): corrupted unsorted chunks 3");
unsorted_chunks (av)->bk = bck;
bck->fd = unsorted_chunks (av);
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] malloc: remove redundant check of unsorted bin corruption
2021-04-08 9:29 ` [PATCH 1/1] malloc: remove redundant check of unsorted bin corruption Ayush Mittal
@ 2023-02-22 22:05 ` DJ Delorie
0 siblings, 0 replies; 2+ messages in thread
From: DJ Delorie @ 2023-02-22 22:05 UTC (permalink / raw)
To: Ayush Mittal; +Cc: libc-alpha, maninder1.s, a.sahrawat, akhilesh.k, ayush.m
Ayush Mittal via Libc-alpha <libc-alpha@sourceware.org> writes:
> * malloc/malloc.c (_int_malloc): remove redundant check of
> unsorted bin corruption
>
> With commit "b90ddd08f6dd688e651df9ee89ca3a69ff88cd0c"
> (malloc: Additional checks for unsorted bin integrity),
> same check of (bck->fd != victim) is added before checking of unsorted
> chunk corruption, which was added in "bdc3009b8ff0effdbbfb05eb6b10966753cbf9b8"
> (Added check before removing from unsorted list).
Sorry this one fell through the cracks. LGTM. Pushed.
Reviewed-by: DJ Delorie <dj@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-22 22:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20210408092938epcas5p4c8c403c2aa26d19185e1be641ce293aa@epcas5p4.samsung.com>
2021-04-08 9:29 ` [PATCH 1/1] malloc: remove redundant check of unsorted bin corruption Ayush Mittal
2023-02-22 22:05 ` DJ Delorie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).