public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] support: Free gdb_script_name
@ 2021-05-12  4:37 Siddhesh Poyarekar
  2021-05-12 19:27 ` DJ Delorie
  0 siblings, 1 reply; 2+ messages in thread
From: Siddhesh Poyarekar @ 2021-05-12  4:37 UTC (permalink / raw)
  To: libc-alpha

Identified by static analysis.
---
 support/support_test_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/support/support_test_main.c b/support/support_test_main.c
index cb72512226..07e3cdd173 100644
--- a/support/support_test_main.c
+++ b/support/support_test_main.c
@@ -221,6 +221,7 @@ run_test_function (int argc, char **argv, const struct test_config *config)
       fprintf (gdb_script, "attach %ld\n", (long int) mypid);
       fprintf (gdb_script, "set wait_for_debugger = 0\n");
       fclose (gdb_script);
+      free (gdb_script_name);
     }
 
   /* Wait for the debugger to set wait_for_debugger to zero.  */
-- 
2.31.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] support: Free gdb_script_name
  2021-05-12  4:37 [PATCH] support: Free gdb_script_name Siddhesh Poyarekar
@ 2021-05-12 19:27 ` DJ Delorie
  0 siblings, 0 replies; 2+ messages in thread
From: DJ Delorie @ 2021-05-12 19:27 UTC (permalink / raw)
  To: Siddhesh Poyarekar; +Cc: libc-alpha

Siddhesh Poyarekar via Libc-alpha <libc-alpha@sourceware.org> writes:
> Identified by static analysis.
> ---
>  support/support_test_main.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/support/support_test_main.c b/support/support_test_main.c
> index cb72512226..07e3cdd173 100644
> --- a/support/support_test_main.c
> +++ b/support/support_test_main.c
> @@ -221,6 +221,7 @@ run_test_function (int argc, char **argv, const struct test_config *config)
>        fprintf (gdb_script, "attach %ld\n", (long int) mypid);
>        fprintf (gdb_script, "set wait_for_debugger = 0\n");
>        fclose (gdb_script);
> +      free (gdb_script_name);
>      }
>  
>    /* Wait for the debugger to set wait_for_debugger to zero.  */

LGTM.

Reviewed-by: DJ Delorie <dj@redhat.com>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-12 19:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-12  4:37 [PATCH] support: Free gdb_script_name Siddhesh Poyarekar
2021-05-12 19:27 ` DJ Delorie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).