* test-src in elf/Makefile
@ 2002-09-22 10:15 Andreas Schwab
2002-09-22 13:48 ` Roland McGrath
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Schwab @ 2002-09-22 10:15 UTC (permalink / raw)
To: Roland McGrath; +Cc: libc-hacker
Hi!
What is this supposed to fix:
* elf/Makefile (test-srcs): Add $(modules-names) to it.
test-srcs is supposed to only contain targets for binaries, but
modules-names only contains .so targets.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: test-src in elf/Makefile
2002-09-22 10:15 test-src in elf/Makefile Andreas Schwab
@ 2002-09-22 13:48 ` Roland McGrath
2002-09-23 1:53 ` Andreas Schwab
0 siblings, 1 reply; 4+ messages in thread
From: Roland McGrath @ 2002-09-22 13:48 UTC (permalink / raw)
To: Andreas Schwab; +Cc: libc-hacker
> What is this supposed to fix:
>
> * elf/Makefile (test-srcs): Add $(modules-names) to it.
>
> test-srcs is supposed to only contain targets for binaries, but
> modules-names only contains .so targets.
This was the easy way to make sure that cppflags-iterator.mk got used for
compiling those modules, which should have -DNOT_IN_libc. I now notice
that test-srcs is used for binaries-bounded, which is not appropriate for
these modules, but I am not sure it hurts.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: test-src in elf/Makefile
2002-09-22 13:48 ` Roland McGrath
@ 2002-09-23 1:53 ` Andreas Schwab
2002-09-23 10:44 ` Roland McGrath
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Schwab @ 2002-09-23 1:53 UTC (permalink / raw)
To: Roland McGrath; +Cc: libc-hacker
Roland McGrath <roland@redhat.com> writes:
|> > What is this supposed to fix:
|> >
|> > * elf/Makefile (test-srcs): Add $(modules-names) to it.
|> >
|> > test-srcs is supposed to only contain targets for binaries, but
|> > modules-names only contains .so targets.
|>
|> This was the easy way to make sure that cppflags-iterator.mk got used for
|> compiling those modules, which should have -DNOT_IN_libc. I now notice
|> that test-srcs is used for binaries-bounded, which is not appropriate for
|> these modules, but I am not sure it hurts.
It hurts when compiling with a cross compiler, see the tests target in
Rules:
ifeq ($(cross-compiling),yes)
tests: $(addprefix $(objpfx),$(tests) $(test-srcs))
xtests: tests
else
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: test-src in elf/Makefile
2002-09-23 1:53 ` Andreas Schwab
@ 2002-09-23 10:44 ` Roland McGrath
0 siblings, 0 replies; 4+ messages in thread
From: Roland McGrath @ 2002-09-23 10:44 UTC (permalink / raw)
To: Andreas Schwab; +Cc: libc-hacker
> It hurts when compiling with a cross compiler, see the tests target in
> Rules:
Ah, ok. I see. Thanks. I've replaced the use I added with a new variable
`test-extras', which is used to give the right CPPFLAGS settings to all
those modules but not for anything else.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2002-09-23 17:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-09-22 10:15 test-src in elf/Makefile Andreas Schwab
2002-09-22 13:48 ` Roland McGrath
2002-09-23 1:53 ` Andreas Schwab
2002-09-23 10:44 ` Roland McGrath
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).