From: Roland McGrath <roland@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: GNU libc hackers <libc-hacker@sources.redhat.com>
Subject: __builtin_frame_address vs %esp in pt-machine.h
Date: Sat, 05 Oct 2002 15:06:00 -0000 [thread overview]
Message-ID: <200210052155.g95LtK226078@magilla.sf.frob.com> (raw)
What was the reason for this change in linuxthreads?
2001-04-12 Ulrich Drepper <drepper@redhat.com>
* sysdeps/i386/Makefile: Make sure gcc uses a frame pointer for
all the files which use CURRENT_STACK_FRAME.
* sysdeps/i386/pt-machine.h (CURRENT_STACK_FRAME): Define using
__builtin_frame_address.
* sysdeps/i386/i686/pt-machine.h: Likewise.
The -fomit-frame-pointer build is broken for !FLOATING_STACKS because we
failed to keep the sysdeps/i386/Makefile up to date with every source file
that uses THREAD_*MEM (probably my fault). The plan of adding all such
files to sysdeps/i386/Makefile seems very error prone (cf the current
error) and definitely ugly. It would be safest to apply it to all the
linuxthreads source files.
But I don't see why we don't just use the definition that works with or
without -fomit-frame-pointer. I don't get any compilation errors from
reverting this change. So I wonder what motivated it. Going back to using
%esp in a global register variable seems like the best way to fix the
current problems to me.
next reply other threads:[~2002-10-05 21:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-05 15:06 Roland McGrath [this message]
2002-10-06 13:24 ` Ulrich Drepper
2002-10-18 13:04 ` Roland McGrath
2002-10-18 20:43 ` Ulrich Drepper
2002-11-06 0:58 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200210052155.g95LtK226078@magilla.sf.frob.com \
--to=roland@redhat.com \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).