From: Roland McGrath <roland@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: GNU libc hackers <libc-hacker@sources.redhat.com>
Subject: Re: __builtin_frame_address vs %esp in pt-machine.h
Date: Wed, 06 Nov 2002 00:58:00 -0000 [thread overview]
Message-ID: <200211060858.gA68wAE29263@magilla.sf.frob.com> (raw)
In-Reply-To: Ulrich Drepper's message of Friday, 18 October 2002 13:10:06 -0700 <3DB06A9E.40208@redhat.com>
> Roland McGrath wrote:
> > I don't understand this. Its use is to check whether another frame's auto
> > variable address might be below (off the top) of the current stack.
>
> I've no time to think about the reason I had to make the change in the
> moment. But I added this code to fix a bug. It is a necessary change.
Bah! I searched all the logs and mailing list archives I could find and
didn't see anything that would have explained the problem, like a related
bug report around the time of the change. This is why you write comments
in the code when there are nonobvious reasons for how it is!
I still cannot imagine any reason why %esp would not be right for
ptlongjmp.c's use (and any other).
prev parent reply other threads:[~2002-11-06 8:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-05 15:06 Roland McGrath
2002-10-06 13:24 ` Ulrich Drepper
2002-10-18 13:04 ` Roland McGrath
2002-10-18 20:43 ` Ulrich Drepper
2002-11-06 0:58 ` Roland McGrath [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200211060858.gA68wAE29263@magilla.sf.frob.com \
--to=roland@redhat.com \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).