From: Ulrich Drepper <drepper@redhat.com>
To: Roland McGrath <roland@redhat.com>
Cc: GNU libc hackers <libc-hacker@sources.redhat.com>
Subject: Re: __builtin_frame_address vs %esp in pt-machine.h
Date: Sun, 06 Oct 2002 13:24:00 -0000 [thread overview]
Message-ID: <3D9F6251.30000@redhat.com> (raw)
In-Reply-To: <200210052155.g95LtK226078@magilla.sf.frob.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Roland McGrath wrote:
> What was the reason for this change in linuxthreads?
>
> 2001-04-12 Ulrich Drepper <drepper@redhat.com>
>
> * sysdeps/i386/Makefile: Make sure gcc uses a frame pointer for
> all the files which use CURRENT_STACK_FRAME.
> * sysdeps/i386/pt-machine.h (CURRENT_STACK_FRAME): Define using
> __builtin_frame_address.
> * sysdeps/i386/i686/pt-machine.h: Likewise.
>
> The -fomit-frame-pointer build is broken for !FLOATING_STACKS because we
> failed to keep the sysdeps/i386/Makefile up to date with every source file
> that uses THREAD_*MEM (probably my fault).
The problem is the ptlongjmp.c code. For its use of CURRENT_STACK_FRAME
the value must be as accurate as possible since otherwise the detection
of frames which have to be handled might be wrong.
- --
- --------------. ,-. 444 Castro Street
Ulrich Drepper \ ,-----------------' \ Mountain View, CA 94041 USA
Red Hat `--' drepper at redhat.com `---------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQE9n2JS2ijCOnn/RHQRAt2OAKCEdBga2IxMC/OtPCp2tQMKGWX+aQCfabYC
6c2IjgwOL7L+AI185XQGefQ=
=FjmT
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2002-10-05 22:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-05 15:06 Roland McGrath
2002-10-06 13:24 ` Ulrich Drepper [this message]
2002-10-18 13:04 ` Roland McGrath
2002-10-18 20:43 ` Ulrich Drepper
2002-11-06 0:58 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D9F6251.30000@redhat.com \
--to=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).