* init-first.c change
@ 2002-10-25 12:42 Jakub Jelinek
2002-10-25 17:33 ` Roland McGrath
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2002-10-25 12:42 UTC (permalink / raw)
To: Roland McGrath; +Cc: Glibc hackers
Hi!
I have doubts about:
2002-10-24 Roland McGrath <roland@redhat.com>
* sysdeps/unix/sysv/linux/init-first.c (init): Protect _dl_starting_up
access with [! SHARED].
* sysdeps/unix/sysv/aix/init-first.c (init): Likewise.
change. It seems to me that ATM all normal dynamically linked programs
will suddenly have __libc_multiple_libcs set to 1 while they had 0 there
previously. Shouldn't it actually be #ifdef SHARED?
Also:
/* The next variable is only here to work around a bug in gcc <= 2.7.2.2.
If the address would be taken inside the expression the optimizer
would try to be too smart and throws it away. Grrr. */
int *dummy_addr = &_dl_starting_up;
__libc_multiple_libcs = dummy_addr && !_dl_starting_up;
could be replaced with
__libc_multiple_libcs = &_dl_starting_up && !_dl_starting_up;
, because we don't support 2.7.2.2 any longer for glibc build.
Last, there is _dl_starting_up extern in elf/dl-init.c which could be
killed too.
Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: init-first.c change
2002-10-25 12:42 init-first.c change Jakub Jelinek
@ 2002-10-25 17:33 ` Roland McGrath
0 siblings, 0 replies; 2+ messages in thread
From: Roland McGrath @ 2002-10-25 17:33 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Glibc hackers
Quite right. I changed it to match the sysdeps/generic code, but that code
is quite bit-rotted and I was forgetting about the view from the dlopen'd
libc.so when thinking about that variable.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-10-25 19:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-10-25 12:42 init-first.c change Jakub Jelinek
2002-10-25 17:33 ` Roland McGrath
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).