sysdeps/generic

sysdeps/generic

[Ulrich Drepper]

As yo might have seen. I've checked in tons of patches to files in 
sysdeps/generic.  In fact, they are gone from sysdeps/generic and placed 
in the appropriate toplevel dirs.

Beside grouping sources more nicely together this also eliminates the 
need to move files to sysdeps/generic to add an arch/platform specific 
file.  Specifically, this makes the patch for the move of the complex 
math functions obsolete.

I've quite thoroughly checked that the result didn't change on x86-64. 
I looked at all the dependency files for changes.  There are no 
unexpected ones.  Then I test compiled x86 and ppc64 without problems.

There are most likely problems for other archs lurking.  So, test it out.

The check-in is actually still going on.  My horribly slow line coupled 
with cvs's crappy protocol make it slow.  So, avoid checking sources in 
or out until you see no more traffic for a while.  I'll not wait until 
this is down, it'll be another hour or two.  It's really time to move to 
monotone...

Tomorrow morning I'll do more consistency checks and will send another 
mail announcing that the repository is consistent again.

-- 
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖

Re: sysdeps/generic

[Andreas Schwab]

Ulrich Drepper <drepper@redhat.com> writes:

> It's really time to move to monotone...

Savannah offers Arch now ... :-)

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: sysdeps/generic

[Ulrich Drepper]

The check-in went fine, all is checked in.

If you have the chance, do a build on your arch(s) of interest before 
updating cvs.  Then again with the same options after the update and 
compare the builds.

Just run size on libc_pic.a and find the files which changed.  These 
should be only a few.  The look at the sections in the changed files.  I 
found only changes in debug info and unwind sections and those changes 
are related to some path changes.  I think  I had in total 6 files which 
changed on x86-64.

Things that need work: add-ons.  Specifically the rtkio (LT should not 
be an issue since it doesn't work on the trunk anyway).  What is needed 
for rtkio are a few files with

   #include "../rt/*.c"

-- 
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖

Re: sysdeps/generic

[Andreas Schwab]

These two changes are needed:

2005-12-15  Andreas Schwab  <schwab@suse.de>

	* sysdeps/unix/sysv/linux/sched_getaffinity.c: Adjust for move of
	generic files.
	* sysdeps/unix/sysv/linux/sched_setaffinity.c: Likewise.

Index: sysdeps/unix/sysv/linux/sched_getaffinity.c
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/unix/sysv/linux/sched_getaffinity.c,v
retrieving revision 1.4
diff -u -a -p -r1.4 sched_getaffinity.c
--- sysdeps/unix/sysv/linux/sched_getaffinity.c	29 Mar 2004 21:58:46 -0000	1.4
+++ sysdeps/unix/sysv/linux/sched_getaffinity.c	14 Dec 2005 23:17:50 -0000
@@ -54,5 +54,5 @@ __sched_getaffinity_old (pid_t pid, cpu_
 compat_symbol (libc, __sched_getaffinity_old, sched_getaffinity, GLIBC_2_3_3);
 # endif
 #else
-# include <sysdeps/generic/sched_getaffinity.c>
+# include <posix/sched_getaffinity.c>
 #endif
Index: sysdeps/unix/sysv/linux/sched_setaffinity.c
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/unix/sysv/linux/sched_setaffinity.c,v
retrieving revision 1.5
diff -u -a -p -r1.5 sched_setaffinity.c
--- sysdeps/unix/sysv/linux/sched_setaffinity.c	18 Jun 2004 02:47:27 -0000	1.5
+++ sysdeps/unix/sysv/linux/sched_setaffinity.c	14 Dec 2005 23:17:50 -0000
@@ -84,5 +84,5 @@ __sched_setaffinity_old (pid_t pid, cons
 compat_symbol (libc, __sched_setaffinity_old, sched_setaffinity, GLIBC_2_3_3);
 # endif
 #else
-# include <sysdeps/generic/sched_setaffinity.c>
+# include <posix/sched_setaffinity.c>
 #endif

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: sysdeps/generic

[Kaz Kojima]

> There are most likely problems for other archs lurking.  So, test it out.

The attached tiny change is needed for SH.

Regards,
	kaz
--
2005-12-15  Kaz Kojima  <kkojima@rr.iij4u.or.jp>

	* sysdeps/gnu/glob64.c: Adjust for files moving out of
	sysdeps/generic.

diff -uprN ORIG/libc/sysdeps/gnu/glob64.c LOCAL/libc/sysdeps/gnu/glob64.c
--- ORIG/libc/sysdeps/gnu/glob64.c	2004-07-02 02:39:25.000000000 +0900
+++ LOCAL/libc/sysdeps/gnu/glob64.c	2005-12-15 15:35:35.000000000 +0900
@@ -19,7 +19,7 @@
 
 #define COMPILE_GLOB64	1
 
-#include <sysdeps/generic/glob.c>
+#include <posix/glob.c>
 
 libc_hidden_def (glob64)
 libc_hidden_def (globfree64)

Re: sysdeps/generic

[Roland McGrath]

I did a global edit to fix up all the references in the tree.
Please test for lingering issues.