* [PATCH]: Missing Sparc Implies
@ 2006-02-24 23:47 David S. Miller
2006-02-25 0:47 ` Roland McGrath
0 siblings, 1 reply; 9+ messages in thread
From: David S. Miller @ 2006-02-24 23:47 UTC (permalink / raw)
To: libc-hacker
Some sparcv9b/Implies files were missing under NPTL breaking
the build of target sparcv9b-* with NPTL enabled.
Please apply, thanks.
2006-02-24 David S. Miller <davem@sunset.davemloft.net>
* sysdeps/sparc/sparc32/sparcv9b/Implies: New file.
* sysdeps/unix/sysv/linux/sparc/sparc32/sparcv9b/Implies: New file.
--- ./nptl/sysdeps/sparc/sparc32/sparcv9b/Implies.~1~ 2006-02-23 16:55:11.000000000 -0800
+++ ./nptl/sysdeps/sparc/sparc32/sparcv9b/Implies 2006-02-23 16:55:03.000000000 -0800
@@ -0,0 +1 @@
+sparc/sparc32/sparcv9
--- ./nptl/sysdeps/unix/sysv/linux/sparc/sparc32/sparcv9b/Implies.~1~ 2006-02-23 16:53:32.000000000 -0800
+++ ./nptl/sysdeps/unix/sysv/linux/sparc/sparc32/sparcv9b/Implies 2006-02-23 16:54:35.000000000 -0800
@@ -0,0 +1 @@
+unix/sysv/linux/sparc/sparc32/sparcv9
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH]: Missing Sparc Implies
2006-02-24 23:47 [PATCH]: Missing Sparc Implies David S. Miller
@ 2006-02-25 0:47 ` Roland McGrath
2006-02-25 1:24 ` David S. Miller
0 siblings, 1 reply; 9+ messages in thread
From: Roland McGrath @ 2006-02-25 0:47 UTC (permalink / raw)
To: David S. Miller; +Cc: libc-hacker
I don't think ought to be necessary. If it is, I'd like to fix the
configure magic so it's not. Those Implies files from the main source
should cause those add-on directories to be searched too.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH]: Missing Sparc Implies
2006-02-25 0:47 ` Roland McGrath
@ 2006-02-25 1:24 ` David S. Miller
2006-02-25 1:41 ` Roland McGrath
0 siblings, 1 reply; 9+ messages in thread
From: David S. Miller @ 2006-02-25 1:24 UTC (permalink / raw)
To: roland; +Cc: libc-hacker
From: Roland McGrath <roland@redhat.com>
Date: Fri, 24 Feb 2006 16:47:08 -0800 (PST)
> I don't think ought to be necessary. If it is, I'd like to fix the
> configure magic so it's not. Those Implies files from the main source
> should cause those add-on directories to be searched too.
This doesn't happen in the top-level either, that's why we need
sysdeps/unix/sysv/linux/sparc/sparc32/sparcv9b/Implies and friends
eventhough we have sysdeps/sparc/sparc32/sparcv9b/Implies.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH]: Missing Sparc Implies
2006-02-25 1:24 ` David S. Miller
@ 2006-02-25 1:41 ` Roland McGrath
2006-02-25 1:45 ` David S. Miller
0 siblings, 1 reply; 9+ messages in thread
From: Roland McGrath @ 2006-02-25 1:41 UTC (permalink / raw)
To: David S. Miller; +Cc: libc-hacker
> From: Roland McGrath <roland@redhat.com>
> Date: Fri, 24 Feb 2006 16:47:08 -0800 (PST)
>
> > I don't think ought to be necessary. If it is, I'd like to fix the
> > configure magic so it's not. Those Implies files from the main source
> > should cause those add-on directories to be searched too.
>
> This doesn't happen in the top-level either, that's why we need
> sysdeps/unix/sysv/linux/sparc/sparc32/sparcv9b/Implies and friends
> eventhough we have sysdeps/sparc/sparc32/sparcv9b/Implies.
I'm not following you. The main tree tree has
sysdeps/unix/sysv/linux/sparc/sparc32/sparcv9b/Implies already.
Another one should not be required in the add-on too.
The one would not be required either if we used sparcv9/sparcv9b instead.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH]: Missing Sparc Implies
2006-02-25 1:41 ` Roland McGrath
@ 2006-02-25 1:45 ` David S. Miller
2006-02-25 1:46 ` Roland McGrath
0 siblings, 1 reply; 9+ messages in thread
From: David S. Miller @ 2006-02-25 1:45 UTC (permalink / raw)
To: roland; +Cc: libc-hacker
From: Roland McGrath <roland@redhat.com>
Date: Fri, 24 Feb 2006 17:41:43 -0800 (PST)
> > From: Roland McGrath <roland@redhat.com>
> > Date: Fri, 24 Feb 2006 16:47:08 -0800 (PST)
> >
> > > I don't think ought to be necessary. If it is, I'd like to fix the
> > > configure magic so it's not. Those Implies files from the main source
> > > should cause those add-on directories to be searched too.
> >
> > This doesn't happen in the top-level either, that's why we need
> > sysdeps/unix/sysv/linux/sparc/sparc32/sparcv9b/Implies and friends
> > eventhough we have sysdeps/sparc/sparc32/sparcv9b/Implies.
>
> I'm not following you. The main tree tree has
> sysdeps/unix/sysv/linux/sparc/sparc32/sparcv9b/Implies already.
> Another one should not be required in the add-on too.
> The one would not be required either if we used sparcv9/sparcv9b instead.
I guess I don't understand how the "machine=" specification in the
configure scripts work... They look like file path names that the
build machinery tries one by one like this:
machine=a/b/c/d
step 1) try $(foo)/a/b/c/d
step 2) try $(foo)/a/b/c
step 3) try $(foo)/a/b
step 4) try $(foo)/a
You seem to be suggesting that it works another way.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH]: Missing Sparc Implies
2006-02-25 1:45 ` David S. Miller
@ 2006-02-25 1:46 ` Roland McGrath
2006-02-25 1:58 ` David S. Miller
0 siblings, 1 reply; 9+ messages in thread
From: Roland McGrath @ 2006-02-25 1:46 UTC (permalink / raw)
To: David S. Miller; +Cc: libc-hacker
> I guess I don't understand how the "machine=" specification in the
> configure scripts work... They look like file path names that the
> build machinery tries one by one like this:
>
> machine=a/b/c/d
>
> step 1) try $(foo)/a/b/c/d
> step 2) try $(foo)/a/b/c
> step 3) try $(foo)/a/b
> step 4) try $(foo)/a
>
> You seem to be suggesting that it works another way.
It sounds like you think there's an OR. It's an AND.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH]: Missing Sparc Implies
2006-02-25 1:46 ` Roland McGrath
@ 2006-02-25 1:58 ` David S. Miller
2006-02-25 2:00 ` Roland McGrath
0 siblings, 1 reply; 9+ messages in thread
From: David S. Miller @ 2006-02-25 1:58 UTC (permalink / raw)
To: roland; +Cc: libc-hacker
From: Roland McGrath <roland@redhat.com>
Date: Fri, 24 Feb 2006 17:46:35 -0800 (PST)
> It sounds like you think there's an OR. It's an AND.
How does this look?
2006-02-24 David S. Miller <davem@sunset.davemloft.net>
* configure.in: Add sparcv9 to machine for sparcv9b
* configure: Regenerate
* sysdeps/sparc/sparc32/sparcv9b/Implies: Delete.
* sysdeps/unix/sysv/linux/sparc/sparc32/sparcv9b/Implies: Delete.
--- ./sysdeps/sparc/sparc32/sparcv9b/Implies.~1~ 2001-04-06 15:34:09.000000000 -0700
+++ ./sysdeps/sparc/sparc32/sparcv9b/Implies 2006-02-24 17:54:10.000000000 -0800
@@ -1 +0,0 @@
-sparc/sparc32/sparcv9
--- ./sysdeps/unix/sysv/linux/sparc/sparc32/sparcv9b/Implies.~1~ 2006-02-24 17:57:29.000000000 -0800
+++ ./sysdeps/unix/sysv/linux/sparc/sparc32/sparcv9b/Implies 2006-02-24 17:57:36.000000000 -0800
@@ -1 +0,0 @@
-unix/sysv/linux/sparc/sparc32/sparcv9
--- ./configure.in.~1~ 2006-02-23 01:17:13.000000000 -0800
+++ ./configure.in 2006-02-24 17:53:02.000000000 -0800
@@ -461,7 +461,7 @@ sparcv8 | supersparc | hypersparc)
sparcv8plus | sparcv8plusa | sparcv9)
base_machine=sparc machine=sparc/sparc32/sparcv9 ;;
sparcv8plusb | sparcv9b)
- base_machine=sparc machine=sparc/sparc32/sparcv9b ;;
+ base_machine=sparc machine=sparc/sparc32/sparcv9/sparcv9b ;;
sparc64)
base_machine=sparc machine=sparc/sparc64 ;;
sparc64b)
--- ./configure.~1~ 2006-02-23 01:17:13.000000000 -0800
+++ ./configure 2006-02-24 17:53:20.000000000 -0800
@@ -1975,7 +1975,7 @@ sparcv8 | supersparc | hypersparc)
sparcv8plus | sparcv8plusa | sparcv9)
base_machine=sparc machine=sparc/sparc32/sparcv9 ;;
sparcv8plusb | sparcv9b)
- base_machine=sparc machine=sparc/sparc32/sparcv9b ;;
+ base_machine=sparc machine=sparc/sparc32/sparcv9/sparcv9b ;;
sparc64)
base_machine=sparc machine=sparc/sparc64 ;;
sparc64b)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH]: Missing Sparc Implies
2006-02-25 1:58 ` David S. Miller
@ 2006-02-25 2:00 ` Roland McGrath
2006-02-25 2:07 ` David S. Miller
0 siblings, 1 reply; 9+ messages in thread
From: Roland McGrath @ 2006-02-25 2:00 UTC (permalink / raw)
To: David S. Miller; +Cc: libc-hacker
> 2006-02-24 David S. Miller <davem@sunset.davemloft.net>
>
> * configure.in: Add sparcv9 to machine for sparcv9b
> * configure: Regenerate
> * sysdeps/sparc/sparc32/sparcv9b/Implies: Delete.
> * sysdeps/unix/sysv/linux/sparc/sparc32/sparcv9b/Implies: Delete.
This looks right to me. But please verify that is actually behaves
correctly as I've said it will.
Thanks,
Roland
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH]: Missing Sparc Implies
2006-02-25 2:00 ` Roland McGrath
@ 2006-02-25 2:07 ` David S. Miller
0 siblings, 0 replies; 9+ messages in thread
From: David S. Miller @ 2006-02-25 2:07 UTC (permalink / raw)
To: roland; +Cc: libc-hacker
From: Roland McGrath <roland@redhat.com>
Date: Fri, 24 Feb 2006 18:00:39 -0800 (PST)
> > 2006-02-24 David S. Miller <davem@sunset.davemloft.net>
> >
> > * configure.in: Add sparcv9 to machine for sparcv9b
> > * configure: Regenerate
> > * sysdeps/sparc/sparc32/sparcv9b/Implies: Delete.
> > * sysdeps/unix/sysv/linux/sparc/sparc32/sparcv9b/Implies: Delete.
>
> This looks right to me. But please verify that is actually behaves
> correctly as I've said it will.
It does, here is what we get for sysdep dirs for sparc9b-linux with
that patch applied:
sysdeps/sparc/sparc32/elf sysdeps/sparc/elf nptl/sysdeps/unix/sysv/linux/sparc/sparc32/sparcv9 sysdeps/unix/sysv/linux/sparc/sparc32/sparcv9 sysdeps/unix/sysv/linux/sparc/sparc32/fpu sysdeps/sparc/sparc32/fpu nptl/sysdeps/unix/sysv/linux/sparc/sparc32 sysdeps/unix/sysv/linux/sparc/sparc32 sysdeps/ieee754/ldbl-64-128 sysdeps/ieee754/ldbl-opt nptl/sysdeps/unix/sysv/linux/sparc sysdeps/unix/sysv/linux/sparc nptl/sysdeps/unix/sysv/linux nptl/sysdeps/pthread sysdeps/pthread sysdeps/unix/sysv/linux sysdeps/gnu sysdeps/unix/common sysdeps/unix/mman sysdeps/unix/inet nptl/sysdeps/unix/sysv sysdeps/unix/sysv sysdeps/unix/sparc nptl/sysdeps/unix sysdeps/unix sysdeps/posix nptl/sysdeps/sparc/sparc32/sparcv9 sysdeps/sparc/sparc32/sparcv9 nptl/sysdeps/sparc/sparc32 sysdeps/sparc/sparc32 sysdeps/wordsize-32 sysdeps/ieee754/ldbl-128 sysdeps/ieee754/dbl-64 sysdeps/ieee754/flt-32 sysdeps/sparc/sparc32/soft-fp sysdeps/sparc/fpu nptl/sysdeps/sparc sysdeps/sparc nptl/sysdeps/generic sysdeps/ieee754 sysdeps/generic/elf sysdeps/generic
The directories added compare to before my patch are:
nptl/sysdeps/unix/sysv/linux/sparc/sparc32/sparcv9
sysdeps/unix/sysv/linux/sparc/sparc32/sparcv9
nptl/sysdeps/sparc/sparc32/sparcv9
sysdeps/sparc/sparc32/sparcv9
Which is exactly what we want.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2006-02-25 2:07 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-02-24 23:47 [PATCH]: Missing Sparc Implies David S. Miller
2006-02-25 0:47 ` Roland McGrath
2006-02-25 1:24 ` David S. Miller
2006-02-25 1:41 ` Roland McGrath
2006-02-25 1:45 ` David S. Miller
2006-02-25 1:46 ` Roland McGrath
2006-02-25 1:58 ` David S. Miller
2006-02-25 2:00 ` Roland McGrath
2006-02-25 2:07 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).