From: Kaz Kojima <kkojima@rr.iij4u.or.jp>
To: libc-hacker@sources.redhat.com
Subject: About stdlib/strto* change
Date: Mon, 13 Aug 2007 14:56:00 -0000 [thread overview]
Message-ID: <20070813.235606.54189794.kkojima@rr.iij4u.or.jp> (raw)
Hi,
There is a build failure for SH during compiling stdlib/strtold_l.c:
strtold_l.c:61: error: 'strtold_l' aliased to undefined symbol '__strtold_l'
In Aug 6 Roland's change, libc_hidden_proto (__strtold_l) is added
to include/stdlib.h and weak_alias (__STRTOLD, STRTOLD) is added to
stdlib/strtold_l.c. It seems that libc_hedden_def is needed also
for __strtold_l just before the above weak_alias statement. Is it
right? x86 uses sysdeps/ieee754/ldbl-96/strtold_l.c which includes
stdlib/strtod_l.c instead of stdlib/strtold_l.c and the corresponding
libc_hedden_def was added to stdlib/strtod_l.c at that time.
The attached patch works for me, though I suspect that I've missed
something.
Regards,
kaz
--
* stdlib/strtold.c: Add libc_hidden_def.
--- ORIG/libc/stdlib/strtold_l.c 2005-12-14 20:14:13.000000000 +0900
+++ LOCAL/libc/stdlib/strtold_l.c 2007-08-13 20:43:24.000000000 +0900
@@ -1,4 +1,4 @@
-/* Copyright (C) 1999, 2002, 2004 Free Software Foundation, Inc.
+/* Copyright (C) 1999, 2002, 2004, 2007 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
@@ -55,4 +55,7 @@ __STRTOLD (const STRING_TYPE *nptr, STRI
{
return INTERNAL (__STRTOD) (nptr, endptr, 0, loc);
}
+#if defined _LIBC && !defined USE_WIDE_CHAR
+libc_hidden_def (__STRTOLD)
+#endif
weak_alias (__STRTOLD, STRTOLD)
next reply other threads:[~2007-08-13 14:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-13 14:56 Kaz Kojima [this message]
2007-08-13 15:28 ` Jakub Jelinek
2007-08-13 15:45 ` Kaz Kojima
2007-08-13 15:54 ` Jakub Jelinek
2007-08-13 22:11 ` Kaz Kojima
2007-08-14 14:37 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070813.235606.54189794.kkojima@rr.iij4u.or.jp \
--to=kkojima@rr.iij4u.or.jp \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).