* nscd/netlink changes
@ 2011-10-31 23:47 Roland McGrath
2011-11-01 1:23 ` Ulrich Drepper
0 siblings, 1 reply; 3+ messages in thread
From: Roland McGrath @ 2011-10-31 23:47 UTC (permalink / raw)
To: Ulrich Drepper; +Cc: GNU libc hackers
You use the header <netlink/netlink.h> but this belongs to the libnl
package, which AFAICT we are not actually using. It seems better to do:
diff --git a/nscd/connections.c b/nscd/connections.c
index 1b8a9bd..c741996 100644
--- a/nscd/connections.c
+++ b/nscd/connections.c
@@ -34,7 +34,8 @@
#include <unistd.h>
#include <arpa/inet.h>
#ifdef HAVE_NETLINK
-# include <netlink/netlink.h>
+# include <linux/netlink.h>
+# include <linux/rtnetlink.h>
#endif
#ifdef HAVE_EPOLL
# include <sys/epoll.h>
Next, I suspect you had some nscd/Makefile changes that you didn't commit.
The check_pf.c changes seem to suggest that you want to compile that file
separately into nscd rather than using the library version. But nothing
does that. This results in nscd not linking because __bump_nl_timestamp
is not an exported function in the library version of the code.
Thanks,
Roland
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: nscd/netlink changes
2011-10-31 23:47 nscd/netlink changes Roland McGrath
@ 2011-11-01 1:23 ` Ulrich Drepper
2011-11-01 16:44 ` Roland McGrath
0 siblings, 1 reply; 3+ messages in thread
From: Ulrich Drepper @ 2011-11-01 1:23 UTC (permalink / raw)
To: Roland McGrath; +Cc: GNU libc hackers
On Mon, Oct 31, 2011 at 19:47, Roland McGrath <roland@hack.frob.com> wrote:
> You use the header <netlink/netlink.h> but this belongs to the libnl
> package, which AFAICT we are not actually using.
I don't see any indication that this is the case. Where do you get this from?
> Next, I suspect you had some nscd/Makefile changes that you didn't commit.
> The check_pf.c changes seem to suggest that you want to compile that file
> separately into nscd rather than using the library version. But nothing
> does that.
The file is included in gai.c.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: nscd/netlink changes
2011-11-01 1:23 ` Ulrich Drepper
@ 2011-11-01 16:44 ` Roland McGrath
0 siblings, 0 replies; 3+ messages in thread
From: Roland McGrath @ 2011-11-01 16:44 UTC (permalink / raw)
To: Ulrich Drepper; +Cc: GNU libc hackers
> > You use the header <netlink/netlink.h> but this belongs to the libnl
> > package, which AFAICT we are not actually using.
>
> I don't see any indication that this is the case. Where do you get this from?
On an rpm-based system, use "rpm -qf /usr/include/netlink/netlink.h".
> The file is included in gai.c.
I see, sorry. My build had some missing .d files so I failed to recompile it.
Thanks,
Roland
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-01 16:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-31 23:47 nscd/netlink changes Roland McGrath
2011-11-01 1:23 ` Ulrich Drepper
2011-11-01 16:44 ` Roland McGrath
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).